Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattergl fill - autorange and restyle #2354

Closed
alexcjohnson opened this issue Feb 9, 2018 · 5 comments
Closed

scattergl fill - autorange and restyle #2354

alexcjohnson opened this issue Feb 9, 2018 · 5 comments
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

scattergl doesn't match the scatter svg autorange behavior with fill: for example, fill: 'tozeroy' like in the gl2d_axes_labels2 mock should trigger the y axis to autorange to zero, and the x axis to autorange tightly rather than padded, despite the markers.

Also: open the same mock and Plotly.restyle(gd, {fill: 'none'}) - the fill will not disappear, though if you add a fill to a plot that doesn't have one, it will appear.

@alexcjohnson alexcjohnson added the bug something broken label Feb 9, 2018
@etpinard
Copy link
Contributor

etpinard commented Feb 9, 2018

Also: open the same mock and Plotly.restyle(gd, {fill: 'none'}) - the fill will not disappear, though if you add a fill to a plot that doesn't have one, it will appear.

cc @dfcreative


scattergl probably suffers from other autorange bugs and/or discrepancies.

@dy dy mentioned this issue Feb 16, 2018
1 task
@etpinard
Copy link
Contributor

etpinard commented Feb 22, 2018

Plotly.restyle(gd, {fill: 'none'}) - the fill will not disappear

this one is fixed via #2377. The autorange issues prevail.

@etpinard
Copy link
Contributor

@dfcreative I found a pretty bad typo in the scattergl calc step where the marker options container is refered to options.markers here, here, here and here instead of options.markers as set here.

This means that Axis.expand never got the correct size values here and the autorange computation for scattergl were plain wrong. See image diffs in commit 58c2972 .

In short, I'll spend some time during to clean up the scattergl calc, by hopefully reusing as much of Scatter.calc as possible.

@etpinard
Copy link
Contributor

done in #2404

@etpinard
Copy link
Contributor

Related: #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants