From 71db12638d664bb06d99a3d9c61b35717cd0c2ed Mon Sep 17 00:00:00 2001 From: Tomasz Gromadzki Date: Wed, 27 Mar 2024 13:50:50 +0100 Subject: [PATCH] common: temporar fix for improper inline functions parsing Signed-off-by: Tomasz Gromadzki --- utils/call_stacks_analysis/make_extra.py | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/utils/call_stacks_analysis/make_extra.py b/utils/call_stacks_analysis/make_extra.py index bdc1e9cbe91..ae038a56754 100755 --- a/utils/call_stacks_analysis/make_extra.py +++ b/utils/call_stacks_analysis/make_extra.py @@ -424,14 +424,33 @@ def get_callees(calls): callees.extend(v) return list(set(callees)) +# XXX to be redesign +# It seems that cflow properly identifies inline functions but in some +# situations does not pars properly funtions that are used inside inline +# funcion: +# libpmem_init() <__attribute__ ((constructor)) void libpmem_init (void) at /home/tgromadz/repos/pmdk/src/libpmem/libpmem.c:23>: +# common_init() : +# core_init() : +# util_init() +# core_log_init() +# out_init() +# util_mmap_init() +# +# In the above example util_init(), core_log_init(), out_init() are not +# parsed properly. This causes a "not called" error of make_call_stacks.py +# script. +# Acccording to very brife analysis all calles listed on the right hand side +# shall be added to extra_entry_points.txt but they are not required in +# extra_calls.json file +# def main(): - extra_calls = inlines({}) - extra_calls = core_function_pointers(extra_calls) + extra_calls = core_function_pointers({}) extra_calls = pmem_function_pointers(extra_calls) extra_calls = pmemobj_function_pointers(extra_calls) with open("extra_calls.json", "w") as outfile: json.dump(extra_calls, outfile, indent = 4) + extra_calls = inlines(extra_calls) # All functions accessed via function pointers have to be provided # on top of regular API calls for cflow to process their call stacks. extra_entry_points = get_callees(extra_calls)