From 7ff96168a25d4b4efd6430929a6bb4baea2d0fa2 Mon Sep 17 00:00:00 2001 From: Tomasz Gromadzki Date: Mon, 26 Feb 2024 16:11:04 +0100 Subject: [PATCH] common: inrease total stack usage limit causes by new logging function Signed-off-by: Tomasz Gromadzki --- .github/workflows/scan_stack_usage.yml | 6 +++--- utils/call_stacks_analysis/README.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/scan_stack_usage.yml b/.github/workflows/scan_stack_usage.yml index 93f36f59608..09d882fc3ed 100644 --- a/.github/workflows/scan_stack_usage.yml +++ b/.github/workflows/scan_stack_usage.yml @@ -52,13 +52,13 @@ jobs: ./make_extra.py ./make_cflow.sh # The lower limit comes up from the DAOS memory requirements. - # 16kB - 4kB - 1kB = ~11kB + # 16kB - 4kB - 768B = 11520B # 16kB = Stack allocated for a single Argobot's ULT # 4kB = a maximum DAOS' stack usage up to calling a PMDK API calls - # 1kB = safety margin + # 768B = safety margin # ~ = Some OSes, e.g. Ubuntu 22.04, generate call stacks of size # a little bit over the exact limit which is not deemed a problem at the moment. - ./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11296 + ./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11520 - name: List per-function stack usage for all call stacks of interest working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }} diff --git a/utils/call_stacks_analysis/README.md b/utils/call_stacks_analysis/README.md index ee4446dc0c0..4933254effd 100644 --- a/utils/call_stacks_analysis/README.md +++ b/utils/call_stacks_analysis/README.md @@ -15,7 +15,7 @@ ./make_extra.py && \ ./make_cflow.sh && \ ./make_call_stacks.py --filter-api-file examples/api_filter.txt \ - --filter-lower-limit 11296 --dump-all-stacks + --filter-lower-limit 11520 --dump-all-stacks ``` If succesfull, it produces: