Skip to content

Commit

Permalink
test: simplify TESTs files
Browse files Browse the repository at this point in the history
- simple file names
- unconditional test file removal in TEST8

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
  • Loading branch information
grom72 committed Apr 3, 2023
1 parent a2ad95a commit e98eb8f
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/test/RUNTESTS
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ testtype=check
fstype=all
testconfig="./testconfig.sh"
killopt="-k 10s"
runtest_timeout="30m"
runtest_timeout="3m"
use_timeout="ok"
testfile=all
testseq=all
Expand Down
2 changes: 1 addition & 1 deletion src/test/obj_pmalloc_mt/TEST0
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ configure_valgrind helgrind force-enable
setup

PMEM_IS_PMEM_FORCE=1 expect_normal_exit\
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile.TEST0
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile0

pass
2 changes: 1 addition & 1 deletion src/test/obj_pmalloc_mt/TEST1
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ configure_valgrind helgrind force-disable
setup

PMEM_IS_PMEM_FORCE=1 expect_normal_exit\
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile.TEST1
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile1

pass
2 changes: 1 addition & 1 deletion src/test/obj_pmalloc_mt/TEST2
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ configure_valgrind helgrind force-enable
setup

PMEM_IS_PMEM_FORCE=1 expect_normal_exit\
./obj_pmalloc_mt$EXESUFFIX 4 64 4 $DIR/testfile.TEST2
./obj_pmalloc_mt$EXESUFFIX 4 64 4 $DIR/testfile2

pass
2 changes: 1 addition & 1 deletion src/test/obj_pmalloc_mt/TEST3
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ configure_valgrind drd force-enable
setup

PMEM_IS_PMEM_FORCE=1 expect_normal_exit\
./obj_pmalloc_mt$EXESUFFIX 4 64 4 $DIR/testfile.TEST3
./obj_pmalloc_mt$EXESUFFIX 4 64 4 $DIR/testfile3

pass
15 changes: 6 additions & 9 deletions src/test/obj_pmalloc_mt/TEST8
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,20 @@

require_valgrind 3.10
require_fs_type pmem
require_test_type medium
require_test_type long
configure_valgrind helgrind force-enable

setup

if test -f "rm $DIR/testfile.TEST8"; then
rm $DIR/testfile.TEST8
fi
rm -f $DIR/testfile8

PMEM_IS_PMEM_FORCE=1 expect_normal_exit\
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile.TEST8
./obj_pmalloc_mt$EXESUFFIX 32 100 10 $DIR/testfile8

if test -f "rm $DIR/testfile.TEST8"; then
rm $DIR/testfile.TEST8
fi
rm $DIR/testfile8

PMEM_IS_PMEM_FORCE=1 expect_abnormal_exit\
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile.TEST8
./obj_pmalloc_mt$EXESUFFIX 32 1000 100 $DIR/testfile8

check

Expand Down
2 changes: 1 addition & 1 deletion src/test/obj_pmalloc_mt/err8.log.match
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{obj_pmalloc_mt.c:52 alloc_worker} obj_pmalloc_mt/TEST8: Error: assertion failure: a->r->offs[a->idx][i] (0x0) != 0 (0x0)
{obj_pmalloc_mt.c:66 realloc_worker} obj_pmalloc_mt/TEST8: Error: assertion failure: ret (0xffffffffffffffff) == 0 (0x0)

0 comments on commit e98eb8f

Please sign in to comment.