Skip to content

Commit

Permalink
Merge pull request #5856 from janekmi/test-mmap-under-valgrind-comment
Browse files Browse the repository at this point in the history
test: add a comment on the effect of device DAXes order
  • Loading branch information
janekmi committed Aug 7, 2023
2 parents 36ec77b + ff488fd commit f548135
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/test/unittest/unittest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1765,6 +1765,9 @@ function require_mmap_under_valgrind() {
fatal "$FILE_MAX_DAX_DEVICES not found. Run make test."
fi

# XXX The number of device DAXes available under this condition is dependent
# on the size and the order of device DAXes in the testconfig.sh file.
# https://github.com/pmem/pmdk/issues/5615
if [ "$REQUIRE_DAX_DEVICES" -gt "$(< $FILE_MAX_DAX_DEVICES)" ]; then
msg "$UNITTEST_NAME: SKIP: anonymous mmap under Valgrind not possible for $REQUIRE_DAX_DEVICES DAX device(s)."
exit 0
Expand Down

0 comments on commit f548135

Please sign in to comment.