-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove log&blk tests from the libpmempool_rm group #5748
test: remove log&blk tests from the libpmempool_rm group #5748
Conversation
b0be987
to
3be9fa9
Compare
Codecov Report
@@ Coverage Diff @@
## master #5748 +/- ##
==========================================
+ Coverage 70.37% 73.88% +3.50%
==========================================
Files 143 143
Lines 22484 21978 -506
Branches 3763 3697 -66
==========================================
+ Hits 15823 16238 +415
+ Misses 6661 5740 -921 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
src/test/libpmempool_rm/TEST0
line 20 at r1 (raw file):
expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/pool1.obj expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/pool2.obj
What is the purpose of two separate files to be used?
3be9fa9
to
f79374a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/libpmempool_rm/TEST0
line 20 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
What is the purpose of two separate files to be used?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
f79374a
to
de7710b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
This change is