Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove log&blk tests from the libpmempool_rm group #5748

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Jun 26, 2023

This change is Reviewable

@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Jun 26, 2023
@janekmi janekmi added this to the 2.0.0 milestone Jun 26, 2023
@janekmi janekmi force-pushed the remove_log_blk_from_libpmempool_rm branch from b0be987 to 3be9fa9 Compare June 26, 2023 10:44
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #5748 (f79374a) into master (775d429) will increase coverage by 3.50%.
The diff coverage is n/a.

❗ Current head f79374a differs from pull request most recent head de7710b. Consider uploading reports for the commit de7710b to get more accurate results

@@            Coverage Diff             @@
##           master    #5748      +/-   ##
==========================================
+ Coverage   70.37%   73.88%   +3.50%     
==========================================
  Files         143      143              
  Lines       22484    21978     -506     
  Branches     3763     3697      -66     
==========================================
+ Hits        15823    16238     +415     
+ Misses       6661     5740     -921     

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)


src/test/libpmempool_rm/TEST0 line 20 at r1 (raw file):


expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/pool1.obj
expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/pool2.obj

What is the purpose of two separate files to be used?

@janekmi janekmi force-pushed the remove_log_blk_from_libpmempool_rm branch from 3be9fa9 to f79374a Compare June 27, 2023 14:30
Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)


src/test/libpmempool_rm/TEST0 line 20 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

What is the purpose of two separate files to be used?

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi force-pushed the remove_log_blk_from_libpmempool_rm branch from f79374a to de7710b Compare June 28, 2023 11:07
Copy link
Contributor Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit e2d0619 into pmem:master Jun 28, 2023
29 checks passed
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants