test: remove libpmemlog tests and examples

[osalyk]

This change is 

[codecov]

Codecov Report

Merging #5752 (6ada149) into master (34f14bb) will decrease coverage by 1.11%.
The diff coverage is n/a.

❗ Current head 6ada149 differs from pull request most recent head af002a6. Consider uploading reports for the commit af002a6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5752      +/-   ##
==========================================
- Coverage   70.95%   69.85%   -1.11%     
==========================================
  Files         143      143              
  Lines       21985    22493     +508     
  Branches     3698     3763      +65     
==========================================
+ Hits        15600    15713     +113     
- Misses       6385     6780     +395     

[grom72]

Please take a look at:
https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/compat_incompat_features/common.sh#L21
POOL_TYPES=(obj blk log) - > POOL_TYPES=(obj log)
https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/compat_incompat_features/common.sh#L26
create_args[blk]="blk 512 $POOLSET"
and also at:
https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/libpmempool_backup/common.sh#L21

POOL_TYPES=( log obj )
POOL_CREATE_PARAMS=( "" "--layout test_layout" )
POOL_CHECK_PARAMS=( "-s" "-soOaAbZH -l -C" )

Reviewable status: 0 of 109 files reviewed, all discussions resolved

[grom72]

Sorry, my mistake the above lines remove libpmemblk tests but I thought about libpmemlog.

Reviewable status: 0 of 109 files reviewed, all discussions resolved

[grom72]

Please add these changes to Changelog

Reviewed 3 of 109 files at r1, all commit messages.
Reviewable status: 3 of 109 files reviewed, all discussions resolved

[grom72]

Reviewed 76 of 109 files at r1.
Reviewable status: 79 of 109 files reviewed, all discussions resolved

[grom72]

Reviewed 30 of 109 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

[grom72]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

a discussion (no related file):
Please add these changes to Changelog

---

[osalyk]

Please take a look at: https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/compat_incompat_features/common.sh#L21 POOL_TYPES=(obj blk log) - > POOL_TYPES=(obj log) https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/compat_incompat_features/common.sh#L26 create_args[blk]="blk 512 $POOLSET" and also at: https://github.com/osalyk/pmdk/blob/177e2b2ace4dd623a839fc52e8eb5e3fc7b13859/src/test/libpmempool_backup/common.sh#L21

POOL_TYPES=( log obj )
POOL_CREATE_PARAMS=( "" "--layout test_layout" )
POOL_CHECK_PARAMS=( "-s" "-soOaAbZH -l -C" )

Reviewable status: 0 of 109 files reviewed, all discussions resolved

I will make changes to the (lib)pmempool_* tests in a separate PR.

[osalyk]

Reviewable status: 109 of 147 files reviewed, 1 unresolved discussion (waiting on @grom72)

a discussion (no related file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Please add these changes to Changelog

Done.

---

[janekmi]

Just make sure to keep your local master up to date and take a look at other PRs before starting any changes in these directories. I see a potential for overlap here.

Reviewable status: 109 of 147 files reviewed, 1 unresolved discussion (waiting on @grom72)

[janekmi]

Reviewed 14 of 109 files at r1, 35 of 38 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72 and @osalyk)

---

ChangeLog line 3 at r3 (raw file):

	* Unreleased *

	This release :

What kind of formatting is it? xD

---

ChangeLog line 4 at r3 (raw file):

	This release :
	- remove libpmemlog tests and examples

removes

---

src/test/ctl_cow/TEST1 line 0 at r3 (raw file):
We have a slight overlap here: https://github.com/pmem/pmdk/pull/5750/files#diff-0229b322d0c495f758542c99b83a8434d0c03a15c24380d0e61cc2fbe8b24101

I am happy to merge yours first, possibly one from @grom72 removing the blk tests as well and closing mine altogether.
You are approach is a lot more robust in this regard.

---

src/test/ctl_prefault/TEST2 line 0 at r3 (raw file):
The same here: https://github.com/pmem/pmdk/pull/5750/files#diff-5208c8587590f4ab83cda8ac1cef16976dadf4c70398a5376644f6b9315181f1

---

src/test/tools/pmemwrite/write.c line 215 at r3 (raw file):

		break;
	case PMEM_POOL_TYPE_LOG:
		ret = pmemwrite_log(&pmemwrite);

Without (lib)pmempool tests being adjusted to stop using log and blk pools you might experience fails.
I hope my changes sort it out: #5745 #5749 #5748 #5746

[grom72]

Reviewed 35 of 38 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

[grom72]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)

[osalyk]

Reviewable status: 144 of 147 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)

---

ChangeLog line 3 at r3 (raw file):

Previously, janekmi (Jan Michalski) wrote…

What kind of formatting is it? xD

Done.

---

ChangeLog line 4 at r3 (raw file):

Previously, janekmi (Jan Michalski) wrote…

removes

Done.

---

src/test/tools/pmemwrite/write.c line 215 at r3 (raw file):

Previously, janekmi (Jan Michalski) wrote…

Without (lib)pmempool tests being adjusted to stop using log and blk pools you might experience fails.
I hope my changes sort it out: #5745 #5749 #5748 #5746

I withdrew from these changes. I will add them in the next PR

[grom72]

Reviewed 1 of 3 files at r4.
Reviewable status: 145 of 147 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

---

src/test/tools/pmemwrite/write.c line 252 at r4 (raw file):

		break;
	case PMEM_POOL_TYPE_OBJ:
		ret = pmemwrite_obj(&pmemwrite);

It is also a part of my changes, but I think the first PR is the winner.

Code quote:

		break;
	case PMEM_POOL_TYPE_LOG:
		ret = pmemwrite_log(&pmemwrite);
		break;
	case PMEM_POOL_TYPE_OBJ:
		ret = pmemwrite_obj(&pmemwrite);

[janekmi]

Reviewed 95 of 109 files at r1, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)

---

src/test/tools/pmemwrite/Makefile line 25 at r4 (raw file):

# Libpmemblk and libpmemlog are deprecated.
# This flag allows to build tests, examples and benchmarks
# using pmemblk/pmemlog despite the deprecated state.

I guess this comment should be reverted to the original state as well.

[osalyk]

Reviewable status: 143 of 147 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)

---

src/test/tools/pmemwrite/Makefile line 25 at r4 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I guess this comment should be reverted to the original state as well.

Done.

---

src/test/tools/pmemwrite/write.c line 252 at r4 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

It is also a part of my changes, but I think the first PR is the winner.

I backed off these changes until pmempool was cleaned up

[janekmi]

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

[grom72]

Reviewed 2 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)

---

src/test/tools/pmemwrite/Makefile line 15 at r5 (raw file):

LIBPMEM=y
LIBPMEMBLK=y
LIBPMEMLOG=y

Do we need this?

Code quote:

LIBPMEMLOG=y

[grom72]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

---

src/test/tools/pmemwrite/write.c line 252 at r4 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

I backed off these changes until pmempool was cleaned up

Yes, first we have to cleanup tests

[osalyk]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)

---

src/test/tools/pmemwrite/Makefile line 15 at r5 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Do we need this?

The file has been restored

[grom72]

Reviewed 2 of 3 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

[grom72]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

[grom72]

Reviewed 2 of 4 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

[janekmi]

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)