test: avoid unnecessary skip in case of different expected test type #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure_valgrind and require_valgrind shall be used after require_test_type and require_fs_type to avoid SKIPs with message due to unsupported/unselected Valgrind configuration. In case of require_test_type and require_fs_type the SKIP is executed but without message added to a test log. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
grom72
added
QA: CI
osalyk
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
janekmi
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/obj_pmalloc_mt/TEST0 line 13 at r1 (raw file):
require_fs_type pmem non-pmem require_test_type long
I would see these two lines in the opposite order. But I am open to arguments. Just a personal preference I guess.
Suggestion:
require_test_type long
require_fs_type pmem non-pmem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure_valgrind and require_valgrind shall be used after require_test_type and require_fs_type to avoid SKIPs with message due to unsupported/unselected Valgrind configuration.
In case of require_test_type and require_fs_type the SKIP is executed but without message added to a test log.
This change is