Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: install clang-format for cstyle purposes #5843

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Aug 5, 2023

This change is Reviewable

@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Aug 5, 2023
@janekmi janekmi added this to the 2.0.0 milestone Aug 5, 2023
@janekmi janekmi force-pushed the workflow-main-clang-format branch 3 times, most recently from 2c69e20 to 369e211 Compare August 5, 2023 21:34
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #5843 (9609c3c) into master (ee3bb15) will increase coverage by 1.70%.
The diff coverage is n/a.

❗ Current head 9609c3c differs from pull request most recent head 64c2156. Consider uploading reports for the commit 64c2156 to get more accurate results

@@            Coverage Diff             @@
##           master    #5843      +/-   ##
==========================================
+ Coverage   69.29%   70.99%   +1.70%     
==========================================
  Files         131      131              
  Lines       19678    19175     -503     
  Branches     3259     3193      -66     
==========================================
- Hits        13636    13614      -22     
+ Misses       6042     5561     -481     

@janekmi janekmi removed the sprint goal This pull request is part of the ongoing sprint label Aug 7, 2023
@janekmi janekmi removed this from the 2.0.0 milestone Aug 7, 2023
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit 99ab606 into pmem:master Aug 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants