Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add playbook for SDLe host configure #5864

Closed
wants to merge 2 commits into from

Conversation

szczepax
Copy link
Contributor

@szczepax szczepax commented Aug 11, 2023

Added playbook for SDLe scan host configure


This change is Reviewable

@janekmi janekmi added no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint labels Aug 15, 2023
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @szczepax)


utils/ansible/configure-SDLe.yml line 24 at r1 (raw file):

- hosts: "{{ host }}"
# - hosts: localhost
#   connection: local

Let's prepare this playbook for local usage by default

Suggestion:

#- hosts: "{{ host }}"
- hosts: localhost
-  connection: local

utils/ansible/configure-SDLe.yml line 143 at r1 (raw file):

    - name: "Restart runner service"
      shell: |
        systemctl restart actions.runner.pmem-pmdk.*.service

We should stop the service using runner_folder/svc.sh stop|start.


utils/ansible/configure-SDLe.yml line 143 at r1 (raw file):

    - name: "Restart runner service"
      shell: |
        systemctl restart actions.runner.pmem-pmdk.*.service

If we stop the service at the beginning with the abovementioned script svc.sh, we can confirm that the runner service is properly installed on the host.

Copy link
Contributor Author

@szczepax szczepax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied all suggested changes

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @grom72)


utils/ansible/configure-SDLe.yml line 24 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Let's prepare this playbook for local usage by default

Done.


utils/ansible/configure-SDLe.yml line 143 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

We should stop the service using runner_folder/svc.sh stop|start.

Done.


utils/ansible/configure-SDLe.yml line 143 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

If we stop the service at the beginning with the abovementioned script svc.sh, we can confirm that the runner service is properly installed on the host.

Done.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #5864 (345be77) into master (65ca2e9) will increase coverage by 1.72%.
Report is 17 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 345be77 differs from pull request most recent head 2d35fd3. Consider uploading reports for the commit 2d35fd3 to get more accurate results

@@            Coverage Diff             @@
##           master    #5864      +/-   ##
==========================================
+ Coverage   69.29%   71.01%   +1.72%     
==========================================
  Files         131      131              
  Lines       19678    19177     -501     
  Branches     3259     3194      -65     
==========================================
- Hits        13635    13618      -17     
+ Misses       6043     5559     -484     

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @szczepax)

@janekmi
Copy link
Contributor

janekmi commented Aug 29, 2023

I am closing this PR as we agreed offline. To be reopened in a more suitable repository. Thanks!

@janekmi janekmi closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants