Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Refactor examples' cmakes #994

Open
lukaszstolarczuk opened this issue May 20, 2021 · 1 comment
Open

Refactor examples' cmakes #994

lukaszstolarczuk opened this issue May 20, 2021 · 1 comment

Comments

@lukaszstolarczuk
Copy link
Member

lukaszstolarczuk commented May 20, 2021

Rationale

We want to test all examples in the CI and make sure CMake file for each example is proper.

Description

Make use of "per example CMake" (e.g. examples/pmemkv_basic_c/CMakeLists.txt) in the main example CMake (examples/CMakeLists.txt). It will reduce code repetition and actually tests if all our examples work.
We could also make sure all our examples are tested in the CI.

API Changes

no

Implementation details

Use include function or somehow make sure to enter all examples' sub-directories and compile every single example.

@lukaszstolarczuk
Copy link
Member Author

lukaszstolarczuk commented Sep 22, 2021

partially done - we assured all examples are executed in CI (in #1045)

@lukaszstolarczuk lukaszstolarczuk removed the new need to be triaged label Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant