Skip to content

Commit

Permalink
don't download vcredist - let users do that
Browse files Browse the repository at this point in the history
  • Loading branch information
dktapps committed Nov 27, 2024
1 parent d0872a5 commit e14d172
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/main-pm-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,6 @@ jobs:
PM_VERSION_MAJOR: ${{ inputs.pm-version-major }}
PHP_VERSION_BASE: ${{ inputs.php-version-base }}

- name: Download VC++ Redistributable
run: |
#vs17 allows running anything from VS 2015-2022
Invoke-WebRequest -Uri https://aka.ms/vs/17/release/vc_redist.x64.exe -OutFile vc_redist.x64.exe
- name: Prepare artifacts
run: |
mkdir temp
Expand All @@ -186,7 +181,6 @@ jobs:
PHP-${{ inputs.php-version-base }}-Windows-x64-PM${{ inputs.pm-version-major }}*.zip
compile.log
windows-compile-vs.bat
vc_redist.x64.exe
if-no-files-found: error


Expand Down Expand Up @@ -246,7 +240,6 @@ jobs:
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Linux-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-MacOS-*-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Windows-PM${{ inputs.pm-version-major }}/*.zip
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Windows-PM${{ inputs.pm-version-major }}/*.exe
name: PocketMine-MP ${{ inputs.pm-version-major }}.x - Recommended (${{ steps.date.outputs.DATE }})
tag: pm${{ inputs.pm-version-major }}-latest
commit: ${{ github.sha }}
Expand All @@ -263,7 +256,6 @@ jobs:
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Linux-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-MacOS-*-PM${{ inputs.pm-version-major }}/*.tar.gz
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Windows-PM${{ inputs.pm-version-major }}/*.zip
${{ github.workspace }}/PHP-${{ inputs.php-version-base }}-Windows-PM${{ inputs.pm-version-major }}/*.exe
name: PocketMine-MP ${{ inputs.pm-version-major }}.x - All PHP Versions (${{ steps.date.outputs.DATE }})
tag: pm${{ inputs.pm-version-major }}-all-latest
commit: ${{ github.sha }}
Expand Down

0 comments on commit e14d172

Please sign in to comment.