Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Add all base material properties to debugger #23

Open
supermoos opened this issue Apr 4, 2022 · 4 comments · May be fixed by #29
Open

Add all base material properties to debugger #23

supermoos opened this issue Apr 4, 2022 · 4 comments · May be fixed by #29
Labels
1.2.0 enhancement New feature or request

Comments

@supermoos
Copy link

Seems like now it just exposes base color, alpha and lighting.
Since lighting changes the base material perhaps the base materials properties (roughness, transmission etc.) could then be exposed too?

@FarazzShaikh
Copy link
Member

Base material properties can be passed into the component/constructor just like you do for regular materials.

<LayerMaterial roughness={…} transmission={…} />

@supermoos
Copy link
Author

I know, that's not what the issue / feature request was about :-) I'll try and explain it better.
If you look at the screenshot below, it's using DebugLayerMaterial, it would be great if the default props of the base material where visible and adjustable in this dialog too, instead of just base and alpha.
Screenshot 2022-04-04 at 14 15 00

@FarazzShaikh
Copy link
Member

Ahh I see, that would be great but it would clutter up the debug panel with a long list of sliders.

It’s also difficult to extract properties that make sense to be sliders dynamically. I’ll give it a go for the next release but no promises haha

@FarazzShaikh FarazzShaikh reopened this Apr 4, 2022
@FarazzShaikh FarazzShaikh added the enhancement New feature or request label Apr 4, 2022
@FarazzShaikh FarazzShaikh changed the title Expose base material properties in the DebugLayerMaterials panel Add all base material properties to debugger Apr 4, 2022
@supermoos
Copy link
Author

supermoos commented Apr 4, 2022 via email

@FarazzShaikh FarazzShaikh linked a pull request May 1, 2022 that will close this issue
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants