Cannot set quaternion in argsFn of useBox (and other useBody hooks)

[mz8i]

When using one of the hooks like useBox or useTrimesh, one can set rotation inside the object returned from argsFn, but a quaternion property is ignored (the body's rotation will always be reset to zero when dependencies of the useX hook change).

A brief check in the code suggests that the problem is in

use-cannon/packages/cannon-worker-api/src/props-to-body.js

Line 61 in 90dfc12

export const propsToBody = (options) => {

- propsToBody in the worker code only extracts rotation from props, but not quaternion.

The workaround right now is simply to use rotation rather than quaternion, or convert quaternions to Euler angles when saving the rotation externally to later restore it. But as the API allows working only with quaternions, I think it would be appropriate to also allow users to set the body's quaternion in the argsFn of the hooks.

[isaac-mason]

Thanks for working on this @Soham1803

The body props type has both a rotation (euler) and a quaternion prop.

We should update props-to-body.js to support the quaternion prop as well as rotation, rather than treating rotation as a quaternion.

[Soham1803]

Won't these lead to conflicts if we have two different props handling the same property of the body?

[isaac-mason]

We'd just need to prefer one if both are provided, we can document the behaviour.

[Soham1803]

Ok I got it. I hope this #437 solves it. I requested a pull for a new branch. I noticed I had unnecessary changes in my yarn.lock file pushed in the previous branch.

[isaac-mason]

Thanks @Soham1803 🙂 will get this released shortly

[Soham1803]

Well, thanks to you too @isaac-mason for your guidance. 😇

[isaac-mason]

The fix has been released, closing this issue