Replies: 1 comment 1 reply
-
See also #485. Providing |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello. valtio looks interesting, thanks!
I am now figuring out how the library is suitable for serious development. And I was unpleasantly surprised when I saw the
proxySet/proxyMap
implementations.An array is used as a data structure, and
.find
(and similar) is used to implement methods. Performance on large amounts of data will be terrible. And this is exactly whereMap
is usually used for speed/memory optimization.I would advise changing the implementation or, if it is not possible to achieve performance comparable to
Set / Map
, it is better to remove these methods. Do not mislead library users who expect good performance.Beta Was this translation helpful? Give feedback.
All reactions