New AI Apoc feat Existential Risk #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoveBodhi
added a commit
to LoveBodhi/Evolve
that referenced
this pull request
Oct 12, 2023
Argavyon
reviewed
Sep 2, 2024
Comment on lines
+638
to
+642
| let aiApocRaceCount = 0; | ||
|
|
||
| Object.keys(global.stats.synth).forEach(race => { | ||
| aiApocRaceCount++; | ||
| }); |
There was a problem hiding this comment.
Much simpler to go for
const aiApocRaceCount = Object.keys(global.stats.synth).length;
Comment on lines
+390
to
+406
| let checked = `<div class="flexed wide">`; | ||
| let avcounter = 0; | ||
| Object.keys(races).sort((a,b) => races[a].name.localeCompare(races[b].name)).forEach(function (key){ | ||
| if (key !== 'protoplasm' && key !== 'nano' && key !== 'synth' && key !== 'junker'){ | ||
| avcounter++; | ||
| if (global.stats.synth[key]){ | ||
| checked = checked + `<span class="wide iclr${global.stats.synth[key]}">${races[key].name}</span>`; | ||
| } | ||
| else { | ||
| checked = checked + `<span class="wide has-text-danger">${races[key].name}</span>`; | ||
| } | ||
| } | ||
| }); | ||
| checked = checked + `</div>`; | ||
| popover(`f-${feat}`,$(`<div class="wide has-text-label">${feats[feat].desc}</div><div>${loc(`wiki_feat_${feat}`)}</div>${checked}${flair}`),{ | ||
| wide: true | ||
| }); |
There was a problem hiding this comment.
This avoids creating the string through concatenation, and instead uses string templates
const noExistentialRisk = ['protoplasm', 'nano', 'synth', 'junker'];
const existentialProgress = `<div class="flexed wide">${
Object.keys(races)
.filter( (race) => !noExistentialRisk.includes(race) )
.map( (race) => ({ name: races[race].name, achieve: global.stats.synth[key] }) )
.sort( (a, b) => a.name.localeCompare(b.name) )
.map( (race) => `<span class="wide ${
race.achieve ? `iclr${race.achieve}` : 'has-text-danger'
}">${race.name}</span>` )
.join('')
}</div>`;
popover(`f-${feat}`,$(`<div class="wide has-text-label">${feats[feat].desc}</div><div>${loc(`wiki_feat_${feat}`)}</div>${existentialProgress}${flair}`),{
wide: true
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly I wanted to be able to track them, the feat is just icing on top :) Happy to take suggestions on icon, flavor text, etc