Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package #24

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Package #24

merged 11 commits into from
Nov 17, 2023

Conversation

englertr
Copy link
Collaborator

@englertr englertr commented Nov 9, 2023

works locally!
I moved everything with the timeseries to the utils (including scrubbing), so that from the outside its just a single function call

Copy link
Member

@spisakt spisakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a few comments.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
connattractor/utils.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Member

@spisakt spisakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@spisakt spisakt merged commit f11a339 into master Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants