Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psl examples #52

Open
drgona opened this issue Aug 19, 2023 · 1 comment
Open

psl examples #52

drgona opened this issue Aug 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@drgona
Copy link
Collaborator

drgona commented Aug 19, 2023

@aarontuor @aaron-tuor @madelynshapiro

The current toml file does not include all the dependencies necessary to run psl examples in:
https://github.com/pnnl/neuromancer/tree/master/examples/psl

there are broken notebook examples:

all psl examples lack proper documentation to guide the user through the functionality of the library

There are also broken psl examples in the test folder:
https://github.com/pnnl/neuromancer/blob/master/tests/psl/coupled_sys_test.ipynb

Missing dependencies:

  • pygame-menu
  • stable_baselines3

Failing tests in: psl\test_directory.py
assert os.path.normcase(nm_path1)==os.path.normcase(nm_path2), 'installed neuromancer root directory not the same as test root directory' AssertionError: installed neuromancer root directory not the same as test root directory

I am of strong opinion not to include all these psl_gym dependencies in our base environment.
the pygame visualisation should be a separate project independent of Neuromancer for now

@drgona drgona changed the title psl_gym dependencies psl examples and psl_gym dependencies Aug 19, 2023
@drgona drgona added bug Something isn't working documentation Improvements or additions to documentation labels Aug 25, 2023
@madelynshapiro
Copy link
Collaborator

All pslgym code has been removed by #69 . Broken notebook examples are still TODO:

  • /examples/psl/signals.ipynb
  • /examples/psl/systems.ipynb

@drgona drgona changed the title psl examples and psl_gym dependencies psl examples Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants