-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for auto-approval of requests #61
Comments
@wapster182 I've implemented this via a new setting in the settings list and it will be released with the other new functionality that we are discussing. |
@wapster182 this is also now done. Please add the following setting to the settings list: |
I tested this, unfortunately did not work yet. { Do I need to re-run the scripts to create the logic apps? Is there anything changed in them that need to be updated? |
Hey @alexc-MSFT, could you check on this? |
Hi @alexc-MSFT, I just tested it: I Re-deployed the entire enviroment using the PS scripts, unfortunately the same error. Maybe there is something wrong because of the new skip template / default data classification setting? |
I did some further testing. When I use a team site as space type, the logic app flow works and creates the space. I think it has to be a problem with the Teams creation and the new skip template / default data classification. Can you look into this? |
@wapster182 so yes as you say that error is not related to auto approval. Can you check the request in the Provisioning Requests list and look at the values of the 'Teams Template' and 'Teams Template Title' columns? I assume this request is using a custom template which perhaps can't be found. Let me know what those columns are populated with please. Thanks |
@wapster182 I've found the issue, the new setting for hiding the site template screen didn't take into account setting a default teams template (it should be set to 'Standard' for a provisioning request unless a template is specified). I've fixed the app, I just need to repackage it. You will only need to import the updated solution as opposed to any backend components. |
@wapster182 though it is worth noting I am about to push some general bug fixes too |
@wapster182 all done, the latest release contains the above fix and some other bug fixes (azure components) |
@wapster182 so I've had this earlier during a deployment and it was due to the new columns not being created in the Provisioning Types list, we then had to refresh the list data source in the app and then republish. Make sure the columns are created exactly as per this issue - #59. Specifically the ones in the Provisioning Types list. Make sure the name is exactly the same too. |
Suggestion
We would like to have the option to auto approve all requests.
Maybe to make it work faster without the need to implement it into some setting, just give some info how to edit the Flow to auto approve it, so skipping the steps of Approvals (or add some actions in the Flow to set the SharePoint list items Status to approved automatically).
The text was updated successfully, but these errors were encountered: