Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL version indication #2

Open
petko opened this issue Apr 10, 2018 · 5 comments
Open

OpenSSL version indication #2

petko opened this issue Apr 10, 2018 · 5 comments

Comments

@petko
Copy link

petko commented Apr 10, 2018

It would be handy, if there is some indication in the code or in the Readme, which version (the letter after the 1.1.0) of OpenSSL is used for building the libraries. I know that it is the latest available when the libs are build or that I can build them myself, but it will be just easier for people using it to know if they have the latest sub-release.

@aleks-f
Copy link
Member

aleks-f commented Apr 10, 2018

The version is whatever the user links with, so putting that information in readme makes no sense.

As for showing the version used, if poco-supplied OpenSSL windows binaries and headers are used, that is already shown during compilation on windows.

If you'd like to see it on other platforms/compilers, send a pull - bear in mind, the main obstacle is portable #pragma message, so whatever you do, it should be properly ifdef'd.

@aleks-f
Copy link
Member

aleks-f commented Apr 10, 2018

I guess some sort of readme info would make sense for binary distributions
@zosrothko

@zosrothko
Copy link
Member

zosrothko commented Apr 11, 2018

In the NuGet packaging, the poco-1.9.1 is claiming a dependency on the Poco OpenSSL 1.1.0 specificaly packaged for Poco via the NuGet metadata specs.

On the MSI package, nothing is stated right now and a sort of readme should be added one day.

@aleks-f
Copy link
Member

aleks-f commented Apr 12, 2018

@petko I was commenting here thinking it is a poco issue, sorry. My above comments apply for poco.

As for this build here, I'm not sure what you mean - whatever version you specify on the build.ps1 command line, that's what you get. If you specify only 1.1.0, it will pul the most recent letter-version from that release series and then you can look for OPENSSL_VERSION_TEXT define.

@petko
Copy link
Author

petko commented Apr 13, 2018

Aleks, I was referring to the version of the already compiled DLLs in the repository's build directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants