Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Zoom the map when searching by location #13

Open
ryankwirth opened this issue Jun 10, 2020 · 0 comments
Open

[FIX] Zoom the map when searching by location #13

ryankwirth opened this issue Jun 10, 2020 · 0 comments
Labels
effort: 3 The relative effort to address this issue. priority: soon This issue is of medium priority. state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: complicated The situation is complicated; good practices used.

Comments

@ryankwirth
Copy link
Collaborator

ryankwirth commented Jun 10, 2020 •
edited
Loading

Purpose

Currently, clicking on the map causes it to pan/zoom to the nearest city and populate the Omnibox with its name. However, directly searching for a city/state does not have the same pan/zoom behaviour. This issue should address that asymmetry.

💡 Proposed Implementation:

  • Create a context for sharing/setting the current search term from both the Omnibox and Map components
  • Remove the mapValue state in App in favor of the new context
@ryankwirth ryankwirth changed the title Zoom the map when searching by location [FEATURE] Zoom the map when searching by location Jun 13, 2020
@ryankwirth ryankwirth added effort: 3 The relative effort to address this issue. priority: soon This issue is of medium priority. state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: complicated The situation is complicated; good practices used. labels Jun 13, 2020
@ryankwirth ryankwirth changed the title [FEATURE] Zoom the map when searching by location [FIX] Zoom the map when searching by location Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: 3 The relative effort to address this issue. priority: soon This issue is of medium priority. state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. work: complicated The situation is complicated; good practices used.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryankwirth