Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Display site icons for each link in SearchResult #15

Open
ryankwirth opened this issue Jun 10, 2020 · 5 comments
Open

[FEATURE] Display site icons for each link in SearchResult #15

ryankwirth opened this issue Jun 10, 2020 · 5 comments
Labels
effort: 2 The relative effort to address this issue. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. work: obvious The situation is obvious; best practices used.

Comments

@ryankwirth
Copy link
Collaborator

ryankwirth commented Jun 10, 2020 •
edited
Loading

Purpose

Showing icons for incident links in the search results provides a better overview of the available data.

💡 Proposed Implementation:

  • Create a new div list in the SearchResult component
  • Populate the list with icons from the parseUrl(...) hook
@JKirkYuan
Copy link
Collaborator

@RyanWirth addressed in #33 ?

@ryankwirth
Copy link
Collaborator Author

No, I mean in the result list, sort of like the original mockup I made.

@JKirkYuan
Copy link
Collaborator

Oh right, like the pins for search?

@ryankwirth
Copy link
Collaborator Author

Like the Twitter and Instagram icons here:

Search Results

I'll create a new issue for the search pins.

@JKirkYuan
Copy link
Collaborator

I'm gonna setup PR & Issue templates :)

@ryankwirth ryankwirth changed the title Display site icons for each link in SearchResult [FEATURE] Display site icons for each link in SearchResult Jun 13, 2020
@ryankwirth ryankwirth added effort: 2 The relative effort to address this issue. state: approved Approved to proceed. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. work: obvious The situation is obvious; best practices used. labels Jun 13, 2020
@JKirkYuan JKirkYuan removed the state: approved Approved to proceed. label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: 2 The relative effort to address this issue. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. work: obvious The situation is obvious; best practices used.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryankwirth @JKirkYuan