Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: keyboard navigation isn't working as expected #42

Open
pedrowindisch opened this issue Jun 12, 2020 · 0 comments
Open

A11y: keyboard navigation isn't working as expected #42

pedrowindisch opened this issue Jun 12, 2020 · 0 comments

Comments

@pedrowindisch
Copy link
Contributor

Description

The keyboard navigation isn't working as expected.

Current behavior

After pressing tab, the page focus on the search field. The user clicks enter and then the app starts fetching the articles. The first article is focused after pressing tab, but if the user presses it again, the app just opens the article up, which is not the correct behavior. I think this issue is better explained with a visual demonstration, so here's a short GIF I made showing what's happening right now.

This is happening because each result has an onKeyDown listener, which also captures the tab key.

Expected behavior

After the results are fetched and rendered, the user should be able to navigate through them by clicking tab or the arrow down key. If the user wants to open an article, he then would click enter. You can find more information about keyboard accessibility here.

@ryankwirth ryankwirth added bug and removed bug labels Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants