Find BLAS and LAPACK if not using MKL #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdumas
reviewed
Aug 22, 2023
| @@ -19,8 +19,11 @@ if("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "arm64" OR "${CMAKE_OSX_ARCHITECTURES}" M | |||
| # Use Accelerate on macOS M1 | |||
| set(BLA_VENDOR Apple) | |||
| find_package(BLAS REQUIRED) | |||
| else() | |||
| # Use MKL on other platforms | |||
| elseif(POLYSOLVE_WITH_MKL) | |||
There was a problem hiding this comment.
Why would you ever want the system version over the MKL BLAS if available? MKL BLAS should be faster...
There was a problem hiding this comment.
When POLYSOLVE_WITH_MKL=OFF, I would expect MKL to not be used entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.