Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RobustArmijo and refactor Armijo Line Search #53

Merged
merged 13 commits into from
Dec 8, 2023
Merged

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Dec 7, 2023

  • Implement the numerically robust Armijo line search of Longva et al. [2023]

TODO:

  • Re-enable use_grad_norm
  • Only compute new_grad as needed

@zfergus zfergus requested a review from teseoch December 7, 2023 03:31
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (49edbec) 89.12% compared to head (c2656a1) 89.01%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/polysolve/nonlinear/line_search/LineSearch.cpp 72.22% 5 Missing ⚠️
...c/polysolve/nonlinear/line_search/Backtracking.cpp 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   89.12%   89.01%   -0.12%     
==========================================
  Files          49       51       +2     
  Lines        1950     1948       -2     
==========================================
- Hits         1738     1734       -4     
- Misses        212      214       +2     
Flag Coverage Δ
polysolve 89.01% <89.23%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CMakeLists.txt Show resolved Hide resolved
nonlinear-solver-spec.json Show resolved Hide resolved
@zfergus zfergus changed the base branch from main to fix-deps December 8, 2023 03:46
Base automatically changed from fix-deps to main December 8, 2023 04:11
@zfergus zfergus marked this pull request as ready for review December 8, 2023 17:51
@zfergus zfergus requested a review from teseoch December 8, 2023 19:45
@zfergus zfergus merged commit b08ab23 into main Dec 8, 2023
8 of 9 checks passed
@zfergus zfergus deleted the robust-armijo branch December 8, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants