Remove BigDecimal precision field

polypheny · Mar 28, 2024 · 1f8d3f0 · 1f8d3f0
1 parent 0b0969b
commit 1f8d3f0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/...to-interface/src/main/java/org/polypheny/db/protointerface/utils/PolyValueSerializer.java b/...to-interface/src/main/java/org/polypheny/db/protointerface/utils/PolyValueSerializer.java
@@ -389,7 +389,6 @@ private static ProtoBigDecimal serializeBigDecimal( BigDecimal bigDecimal ) {
         return ProtoBigDecimal.newBuilder()
                 .setUnscaledValue( ByteString.copyFrom( bigDecimal.unscaledValue().toByteArray() ) )
                 .setScale( bigDecimal.scale() )
-                .setPrecision( bigDecimal.precision() )
                 .build();
     }
 

diff --git a/...interface/src/main/java/org/polypheny/db/protointerface/utils/ProtoValueDeserializer.java b/...interface/src/main/java/org/polypheny/db/protointerface/utils/ProtoValueDeserializer.java
@@ -170,9 +170,8 @@ private static PolyBigDecimal deserializeToPolyBigDecimal( ProtoValue protoValue
 
     private static BigDecimal deserializeToBigDecimal( ProtoValue protoValue ) {
         ProtoBigDecimal protoBigDecimal = protoValue.getBigDecimal();
-        MathContext context = new MathContext( protoBigDecimal.getPrecision() );
         byte[] unscaledValue = protoBigDecimal.getUnscaledValue().toByteArray();
-        return new BigDecimal( new BigInteger( unscaledValue ), protoBigDecimal.getScale(), context );
+        return new BigDecimal( new BigInteger( unscaledValue ), protoBigDecimal.getScale() );
     }
 
 }
diff --git a/plugins/proto-interface/src/main/proto/polyprism/value.proto b/plugins/proto-interface/src/main/proto/polyprism/value.proto
@@ -199,9 +199,9 @@ Represents a BigDecimal value with specified precision and scale.
 */
 message ProtoBigDecimal {
   // The scale of the BigDecimal.
-  uint32 scale = 1;
+  int32 scale = 1;
   // The precision of the BigDecimal.
-  uint32 precision = 2;
+  uint32 precision = 2;  // TODO: Currently unused
   // The unscaled value of the BigDecimal.
   bytes unscaled_value = 3;
 }