Skip to content

Commit

Permalink
fixes for tuplecount race condition and neo4j errors during graph bench
Browse files Browse the repository at this point in the history
  • Loading branch information
datomo committed Apr 4, 2024
1 parent 726a6a9 commit 5f2b618
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ public Double getTupleCount( AlgNode alg ) {
rowCountHandler = revise( e.algClass, TupleCount.DEF );
} catch ( CyclicMetadataException e ) {
log.warn( "Cyclic metadata detected while computing row count for {}", alg );
return null; // Ignore this algebra expression; there will be non-cyclic ones in this set.
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ static PolyValue asPolyValue( @NonNull Value value ) {
return new PolyList<>( (value).asList( NeoUtil::getComparableOrString ) );
}
throw new NotImplementedException( "Type not supported" );
//return PolyString.of( value.asObject().toString() );
}

static Function1<Record, PolyValue[]> getTypesFunction( NestedPolyType types ) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ private String handleBinaries( RexCall call ) {
RexNode rightRex = call.operands.get( 1 );
String left = leftRex.accept( this );
if ( leftRex.isA( Kind.LITERAL ) && PolyType.STRING_TYPES.contains( leftRex.getType().getPolyType() ) ) {
left = String.format( "'%s'", left );
//left = String.format( "'%s'", left );
}
String right = rightRex.accept( this );
if ( rightRex.isA( Kind.LITERAL ) && PolyType.STRING_TYPES.contains( rightRex.getType().getPolyType() ) ) {
right = String.format( "'%s'", right );
//right = String.format( "'%s'", right );
}

return getFinalFunction( call, List.of( left, right ) );
Expand All @@ -204,7 +204,6 @@ private String handleBinaries( RexCall call ) {


private String handleExtractFromPath( RexCall call ) {
//AlgDataTypeField field = beforeFields.get( ((RexInputRef) call.operands.get( 0 )).getIndex() );
assert call.operands.get( 1 ).isA( Kind.LITERAL );

return ((RexLiteral) call.operands.get( 1 )).value.asString().value;
Expand Down

0 comments on commit 5f2b618

Please sign in to comment.