Do not close connection on error

This default is somewhat better suited for the implementation of interactive shells.
polypheny · Mar 27, 2024 · 6773b1e · 6773b1e
1 parent 7c6ebf4
commit 6773b1e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/org/polypheny/db/languages/LanguageManager.java b/core/src/main/java/org/polypheny/db/languages/LanguageManager.java
@@ -184,7 +184,7 @@ public List<ImplementationContext> anyPrepareQuery( QueryContext context, Statem
                 implementationContexts.add( new ImplementationContext( implementation, parsed, statement, null ) );
 
             } catch ( Throwable e ) {
-                log.warn( "Caught exception: ", e );
+                log.warn( "Caught exception: ", e ); // TODO: This should not log in all cases, at least not with stacktrace
                 if ( transaction.isAnalyze() ) {
                     transaction.getQueryAnalyzer().attachStacktrace( e );
                 }

diff --git a/plugins/proto-interface/src/main/java/org/polypheny/db/protointerface/PIService.java b/plugins/proto-interface/src/main/java/org/polypheny/db/protointerface/PIService.java
@@ -224,7 +224,7 @@ private void handleMessages() throws IOException, ExecutionException, Interrupte
                     handle.join();
                     handle = null;
                     Response r = response.get();
-                    if ( r.getTypeCase() == Response.TypeCase.DISCONNECT_RESPONSE || r.getTypeCase() == Response.TypeCase.ERROR_RESPONSE ) {
+                    if ( r.getTypeCase() == Response.TypeCase.DISCONNECT_RESPONSE ) {
                         throw new EOFException();
                     }
                     response = null;