Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR Protocol Examples #43

Open
frezik opened this issue Mar 2, 2016 · 2 comments
Open

IR Protocol Examples #43

frezik opened this issue Mar 2, 2016 · 2 comments

Comments

@frezik
Copy link
Contributor

frezik commented Mar 2, 2016

I'm not quite sure if the docs are incorrect or if I'm missing something, but I think the examples have a space that shouldn't be there:

id 14: PULSE 300 | SPACE 300 | SPACE 300 | SPACE 300 | PULSE 600 | SPACE 600 | PULSE 600 | SPACE 300 | PULSE 300
id  3: PULSE 300 | SPACE 300 | SPACE 300 | SPACE 300 | PULSE 300 | SPACE 300 | PULSE 600 | SPACE 600 | PULSE 600

My understanding is that every section should alternate between pulses and spaces, so the above should be:

id 14: PULSE 300 | SPACE 300 | PULSE 300 | SPACE 300 | PULSE 600 | SPACE 600 | PULSE 600 | SPACE 300 | PULSE 300
id  3: PULSE 300 | SPACE 300 | PULSE 300 | SPACE 300 | PULSE 300 | SPACE 300 | PULSE 600 | SPACE 600 | PULSE 600
@tb942
Copy link
Contributor

tb942 commented May 4, 2016

ive made a pull request for this bug

@tb942
Copy link
Contributor

tb942 commented May 5, 2016

This has now been merged and fixed, can you close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants