Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a flat titlebar and rounded corners #4

Open
hanaral opened this issue Mar 13, 2021 · 4 comments
Open

Use a flat titlebar and rounded corners #4

hanaral opened this issue Mar 13, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@hanaral
Copy link
Contributor

hanaral commented Mar 13, 2021

There are a couple of ways to do this - altough I tried and couldn't manage to implement the simplest one which is to just use the flat header and rounded window style
So there are 2 options:

  • Either get to the bottom of why the app doesn't get styled OR just rewrite it in Vala and package it as an actual app
  • Another way is to add Hdy as a dep. and use that
@pongloongyeat
Copy link
Owner

pongloongyeat commented Mar 13, 2021

Could you elaborate on what you mean by flat titlebar? Do you mean a smaller titlebar?

rounded window style

Yeah this is an issue since I'd like to avoid adding additional dependencies to the project since the focus of this project was literally just to have a single-file script with a nice GUI on top with as little lines of code as possible. Using a Hdy.Window would be the easiest way around this.

OR just rewrite it in Vala and package it as an actual app

Yeah I'm keen on this idea and it probably wouldn't be too hard to port to Vala since there isn't much functionality right now. I'll have to scour out what additional functionality to add to it though. If there isn't any additional functionality then I'd rather not port to Vala since the Python one does work as what I initially set out for this project. You're welcome to post feature request as issues and if I have enough bundled up I may work on the Vala port.

@hanaral
Copy link
Contributor Author

hanaral commented Mar 13, 2021

Could you elaborate on what you mean by flat titlebar? Do you mean a smaller titlebar?

rounded window style

As in using the flat style like you have in dialogues where the window titlebar is one with the window

Yeah this is an issue since I'd like to avoid adding additional dependencies to the project since the focus of this project was literally just to have a single-file script with a nice GUI on top with as little lines of code as possible. Using a Hdy.Window would be the easiest way around this.

It might be better tbh to just get the app to accept the "rounded" style that exists in the elementary stylesheet since it's worked like a charm in my current work to improve Olifant (elementary Calculator uses it too rather than Hdy)

OR just rewrite it in Vala and package it as an actual app

Yeah I'm keen on this idea and it probably wouldn't be too hard to port to Vala since there isn't much functionality right now. I'll have to scour out what additional functionality to add to it though. If there isn't any additional functionality then I'd rather not port to Vala since the Python one does work as what I initially set out for this project. You're welcome to post feature request as issues and if I have enough bundled up I may work on the Vala port.

I'm trying to bundle the app as a flatpak rn, I kinda wish that the flatpaked elementary app Sdk was officially out, because I'm going to have to specify the locally built one on every launch -_-

@hanaral

This comment has been minimized.

@pongloongyeat

This comment has been minimized.

@pongloongyeat pongloongyeat added the enhancement New feature or request label Mar 15, 2021
@pongloongyeat pongloongyeat added this to the Vala release milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants