Dependence on a closed source server at "popcorn-ru.tk" for binaries

[timebite]

I was looking through the contributing document and trying to get my own local build of PCT when I saw

Isn't this a big security issue? I mean we're downloading a binary from a random source(no offence to the person hosting it). Can't we have a build process written into the workflow, building just the ffmpeg library into a dll/dylib and adding it to the nwjs SDK downloaded from the official site seems very simple as well, source.

Or we could even set up something like this ? I feel like there are a lot of options we could exhaust before relying on a server that has binaries that we have no way of verifying.

[ivan1986]

#2062

[ivan1986]

yes, need build with proprietary codecs, https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases not works - many codecs not exist
i try to build new nwjs by this manual, but do something wrong

[timebite]

@ivan1986 I've made it work with the CI builds from https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases/tag/0.44.6 on a fork here https://github.com/timebite/popcorn-desktop. It uses 0.44.6 instead of 0.44.5 from the official nwjs sources, I wasn't able to make a PR because for some reason the CI build tests on that repo kept failing, I'd be happy to get some pointers on that.

[ivan1986]

1. and now more then half of films in internal player play without sound
2. we wait this feat: Add PE/MSE support webtorrent/webtorrent#1820