Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to deploy a stack when using the relative path option - Error 255 #23

Open
ThaDaVos opened this issue Aug 26, 2023 · 1 comment

Comments

@ThaDaVos
Copy link

Linking from: https://github.com/orgs/portainer/discussions/9300

The compose-unpacker, at least in my case, seems to fail when a private registry is used - even when credentials etc are all correct:

{"level":"info","time":1692996405,"caller":"/home/runner/work/compose-unpacker/compose-unpacker/deploy.go:297","message":"Docker login docker.io successed"}
{"level":"info","time":1692996405,"caller":"/home/runner/work/compose-unpacker/compose-unpacker/deploy.go:323","message":"Docker logout docker.io successed"}
docker login failure

I am creating this issue to check on the code and maybe create a PR eventually - unless this is an already known problem, then hopefully there's a fix in the works already

@ThaDaVos
Copy link
Author

A few things I already see being wrong in the code:

  1. Password is passed plain - so if your password contains a : - it breaks
  2. No support for custom registries which use a port in their definition - breaks as the login is split and checked to be equal to 3

To fix 1: The password should be passed encoded - so it doesn't contain forbidden characters
To fix 2: Different way of parsing of the registry strings which is less faulty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant