Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pyarrow.Table support #487

Merged
merged 16 commits into from
Nov 25, 2024
Merged

feat: add pyarrow.Table support #487

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e627865
Add PyArrow.Table support
amol- Oct 5, 2024
a80a2f7
format
amol- Oct 5, 2024
6477bcb
Update substitutions too
amol- Oct 5, 2024
e6c057a
Update test for set_cell
amol- Oct 5, 2024
ed8e8e0
Update function signature
amol- Oct 5, 2024
e501880
Few typing fixes
amol- Oct 5, 2024
d40040b
Consolidate set_cell immutability behavior
amol- Oct 9, 2024
d3cdd1c
Snapshot test for backends
amol- Oct 9, 2024
e7e9f4e
Use comparing types can use is operator
amol- Oct 9, 2024
e4a2964
Put back empty line wrongly removed by snapshot update
amol- Oct 9, 2024
ccbf413
Limit scope of changes
amol- Oct 11, 2024
38e1286
Increase test coverage and fix group_splits
amol- Oct 17, 2024
492ee51
Test ChunkedArray
amol- Oct 17, 2024
8b9b8de
Cover to_list
amol- Oct 17, 2024
cce64de
Merge branch 'main' into pyarrow
machow Nov 25, 2024
ef41328
dev: warn that pyarrow support is experimental
machow Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
exclude: "(.*\\.svg)|(.*\\.qmd)|(.*\\.ambr)|(.*\\.csv)|(.*\\.txt)|(.*\\.json)"
repos:
- repo: https://github.com/pycqa/flake8
rev: 6.0.0
rev: 7.1.1
machow marked this conversation as resolved.
Show resolved Hide resolved
hooks:
- id: flake8
types:
Expand Down
5 changes: 3 additions & 2 deletions great_tables/_gt_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
copy_data,
create_empty_frame,
get_column_names,
_get_column_dtype,
n_rows,
to_list,
validate_frame,
Expand Down Expand Up @@ -173,7 +174,7 @@ def render_formats(self, data_tbl: TblData, formats: list[FormatInfo], context:
# TODO: I think that this is very inefficient with polars, so
# we could either accumulate results and set them per column, or
# could always use a pandas DataFrame inside Body?
_set_cell(self.body, row, col, result)
self.body = _set_cell(self.body, row, col, result)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time working through this quirk in the formatter 😬

What if we did this for now?:

  • if _set_cell returns something that is not None, we set it to self.body
  • We restore the original behavior of _set_cell returning None for pandas and polars, and mutating them (just to ensure this PR stays scoped to pyarrow).
  • After merging, I can open an issue to refactor this bit of code so it works columnwise (rather than on each individual row, col cell)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds a reasonable approach


return self

Expand Down Expand Up @@ -323,7 +324,7 @@ def align_from_data(self, data: TblData):
# a Pandas DataFrame or a Polars DataFrame
col_classes = []
for col in get_column_names(data):
dtype = data[col].dtype
dtype = _get_column_dtype(data, col)

if dtype == "object":
# Check whether all values in 'object' columns are strings that
Expand Down
Loading