New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not seem to support contentType #36

Open

nitinthewiz opened this issue Jan 29, 2020 · 0 comments

nitinthewiz commented Jan 29, 2020

Platform: AWS Lambda
Mercury Parser API Version: 0.0.1
Node Version: v12.11.1

Expected Behavior

API endpoint should allow contentType as text or markdown

Current Behavior

It seems the contentType argument is not present in the code, as the code only takes url and html from the request -

https://github.com/postlight/mercury-parser-api/blob/b6a04af54b3d734e96aa72e487659c087ba09295/src/parse-html.js#L6

Steps to Reproduce

Hosted on AWS Lambda as per instructions, can provide link if needed.
I just tried to make a GET and POST calls, with the contentType set to text and that doesn't seem to work

Detailed Description

Possible Solution

Code should be updated to accept opts as per Mercury parse - https://github.com/postlight/mercury-parser/blob/b0e708aac6a4e7e10986448a132d60df57c45b00/src/mercury.js#L13

nitinthewiz changed the title ~~Does this support contentType?~~ Does not seem to support contentType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment