Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install xz as regular dependency #482

Merged

Conversation

kattouf
Copy link
Contributor

@kattouf kattouf commented Jun 14, 2024

I found a corner case when previous xz install on macOS implementation doesn't work and propose a solution.

The previous implementation covered cases when we installed ruby-install on macOS via brew and that worked well.
But in our case, we install (implicitly) ruby-install using mise, that don't use brew to install it under the hood, and as a consequence we miss brew formula dependencies installation.

I propose to install xz as part of installing all other dependencies (via system package managers) that cover all cases.

@postmodern postmodern merged commit ca52936 into postmodern:master Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants