From f8c0a4f73751ea69d19ccc8545c32c16a235e3cc Mon Sep 17 00:00:00 2001
From: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Date: Tue, 17 Dec 2024 13:39:37 +0100
Subject: [PATCH] Fix case9241pegase.mat import

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
---
 .../matpower/converter/MatpowerImporter.java  |   5 +-
 .../converter/MatpowerImporterTest.java       |   5 +
 ...ieee14-phase-shifter-zero-ratio-issue.json | 594 ++++++++++++++++++
 ...eee14-phase-shifter-zero-ratio-issue.xiidm | 139 ++++
 .../matpower/model/MatpowerModelFactory.java  |   2 +-
 5 files changed, 743 insertions(+), 2 deletions(-)
 create mode 100644 matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.json
 create mode 100644 matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.xiidm

diff --git a/matpower/matpower-converter/src/main/java/com/powsybl/matpower/converter/MatpowerImporter.java b/matpower/matpower-converter/src/main/java/com/powsybl/matpower/converter/MatpowerImporter.java
index e8d0ff1c719..ad20e9b538b 100644
--- a/matpower/matpower-converter/src/main/java/com/powsybl/matpower/converter/MatpowerImporter.java
+++ b/matpower/matpower-converter/src/main/java/com/powsybl/matpower/converter/MatpowerImporter.java
@@ -354,6 +354,9 @@ private static void createBranches(MatpowerModel model, ContainersMapping contai
 
             Branch<?> branch;
             if (isTransformer(model, mBranch)) {
+                // we might have a matpower branch with a phase shift and a 0 ratio (0 in matpower just means undefined)
+                // we need to create an IIDM transformer but we just in that case fix the ratio to 1
+                double ratio = mBranch.getRatio() == 0 ? 1 : mBranch.getRatio();
                 TwoWindingsTransformer newTwt = voltageLevel2.getSubstation()
                         .orElseThrow(() -> new PowsyblException("Substation null! Transformer must be within a substation"))
                         .newTwoWindingsTransformer()
@@ -365,7 +368,7 @@ private static void createBranches(MatpowerModel model, ContainersMapping contai
                         .setBus2(connectedBus2)
                         .setConnectableBus2(bus2Id)
                         .setVoltageLevel2(voltageLevel2Id)
-                        .setRatedU1(voltageLevel1.getNominalV() * mBranch.getRatio())
+                        .setRatedU1(voltageLevel1.getNominalV() * ratio)
                         .setRatedU2(voltageLevel2.getNominalV())
                         .setR(mBranch.getR() * zb)
                         .setX(mBranch.getX() * zb)
diff --git a/matpower/matpower-converter/src/test/java/com/powsybl/matpower/converter/MatpowerImporterTest.java b/matpower/matpower-converter/src/test/java/com/powsybl/matpower/converter/MatpowerImporterTest.java
index 7218ca727cb..7a1c77bd388 100644
--- a/matpower/matpower-converter/src/test/java/com/powsybl/matpower/converter/MatpowerImporterTest.java
+++ b/matpower/matpower-converter/src/test/java/com/powsybl/matpower/converter/MatpowerImporterTest.java
@@ -95,6 +95,11 @@ void testCase14WithPhaseShifter() throws IOException {
         testCase(MatpowerModelFactory.create14WithPhaseShifter());
     }
 
+    @Test
+    void testCase14WithPhaseShifterZeroRatioIssue() throws IOException {
+        testCase(MatpowerModelFactory.readModelJsonFromResources("ieee14-phase-shifter-zero-ratio-issue.json"));
+    }
+
     @Test
     void testCase14WithPhaseShifterSolved() throws IOException {
         testCaseSolved(MatpowerModelFactory.create14WithPhaseShifter());
diff --git a/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.json b/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.json
new file mode 100644
index 00000000000..06ea26a1ac8
--- /dev/null
+++ b/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.json
@@ -0,0 +1,594 @@
+{
+  "caseName" : "ieee14-phase-shifter-zero-ratio-issue",
+  "baseMva" : 100.0,
+  "version" : "2",
+  "buses" : [ {
+    "number" : 1,
+    "type" : "REF",
+    "realPowerDemand" : 0.0,
+    "reactivePowerDemand" : 0.0,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.06,
+    "voltageAngle" : 0.0,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 2,
+    "type" : "PV",
+    "realPowerDemand" : 21.7,
+    "reactivePowerDemand" : 12.7,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0449999999999997,
+    "voltageAngle" : -5.000328510465844,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 3,
+    "type" : "PV",
+    "realPowerDemand" : 94.2,
+    "reactivePowerDemand" : 19.0,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.01,
+    "voltageAngle" : -12.78892335601888,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 4,
+    "type" : "PQ",
+    "realPowerDemand" : 47.8,
+    "reactivePowerDemand" : -3.9,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0173494845822744,
+    "voltageAngle" : -10.412306262257337,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 5,
+    "type" : "PQ",
+    "realPowerDemand" : 7.6,
+    "reactivePowerDemand" : 1.6,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0200789534978287,
+    "voltageAngle" : -8.724093100611777,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 6,
+    "type" : "PV",
+    "realPowerDemand" : 11.2,
+    "reactivePowerDemand" : 7.5,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.07,
+    "voltageAngle" : -13.22467775771849,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 7,
+    "type" : "PQ",
+    "realPowerDemand" : 0.0,
+    "reactivePowerDemand" : 0.0,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.061731342223832,
+    "voltageAngle" : -10.185085117783457,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 8,
+    "type" : "PV",
+    "realPowerDemand" : 0.0,
+    "reactivePowerDemand" : 0.0,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.09,
+    "voltageAngle" : -10.185085117783467,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 9,
+    "type" : "PQ",
+    "realPowerDemand" : 29.5,
+    "reactivePowerDemand" : 16.6,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 19.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0582629220284285,
+    "voltageAngle" : -12.65099581261227,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 10,
+    "type" : "PQ",
+    "realPowerDemand" : 9.0,
+    "reactivePowerDemand" : 5.8,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0531461836881817,
+    "voltageAngle" : -13.035710471997398,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 11,
+    "type" : "PQ",
+    "realPowerDemand" : 3.5,
+    "reactivePowerDemand" : 1.8,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0582558695370825,
+    "voltageAngle" : -13.25292235374066,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 12,
+    "type" : "PQ",
+    "realPowerDemand" : 6.1,
+    "reactivePowerDemand" : 1.6,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0551462766263606,
+    "voltageAngle" : -13.988186540628082,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 13,
+    "type" : "PQ",
+    "realPowerDemand" : 13.5,
+    "reactivePowerDemand" : 5.8,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.0509495051495474,
+    "voltageAngle" : -13.97721516091526,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  }, {
+    "number" : 14,
+    "type" : "PQ",
+    "realPowerDemand" : 14.9,
+    "reactivePowerDemand" : 5.0,
+    "shuntConductance" : 0.0,
+    "shuntSusceptance" : 0.0,
+    "areaNumber" : 1,
+    "voltageMagnitude" : 1.037140277380203,
+    "voltageAngle" : -14.223902738389041,
+    "baseVoltage" : 0.0,
+    "lossZone" : 1,
+    "maximumVoltageMagnitude" : 1.06,
+    "minimumVoltageMagnitude" : 0.94
+  } ],
+  "generators" : [ {
+    "number" : 1,
+    "realPowerOutput" : 232.49989569603508,
+    "reactivePowerOutput" : -16.899907154008424,
+    "maximumReactivePowerOutput" : 10.0,
+    "minimumReactivePowerOutput" : 0.0,
+    "voltageMagnitudeSetpoint" : 1.06,
+    "totalMbase" : 100.0,
+    "status" : 1,
+    "maximumRealPowerOutput" : 332.4,
+    "minimumRealPowerOutput" : 0.0,
+    "pc1" : 0.0,
+    "pc2" : 0.0,
+    "qc1Min" : 0.0,
+    "qc1Max" : 0.0,
+    "qc2Min" : 0.0,
+    "qc2Max" : 0.0,
+    "rampAgc" : 0.0,
+    "rampTenMinutes" : 0.0,
+    "rampThirtyMinutes" : 0.0,
+    "rampQ" : 0.0,
+    "apf" : 0.0
+  }, {
+    "number" : 2,
+    "realPowerOutput" : 40.0,
+    "reactivePowerOutput" : 43.58509011714705,
+    "maximumReactivePowerOutput" : 50.0,
+    "minimumReactivePowerOutput" : -40.0,
+    "voltageMagnitudeSetpoint" : 1.045,
+    "totalMbase" : 100.0,
+    "status" : 1,
+    "maximumRealPowerOutput" : 140.0,
+    "minimumRealPowerOutput" : 0.0,
+    "pc1" : 0.0,
+    "pc2" : 0.0,
+    "qc1Min" : 0.0,
+    "qc1Max" : 0.0,
+    "qc2Min" : 0.0,
+    "qc2Max" : 0.0,
+    "rampAgc" : 0.0,
+    "rampTenMinutes" : 0.0,
+    "rampThirtyMinutes" : 0.0,
+    "rampQ" : 0.0,
+    "apf" : 0.0
+  }, {
+    "number" : 3,
+    "realPowerOutput" : 0.0,
+    "reactivePowerOutput" : 25.247205918340796,
+    "maximumReactivePowerOutput" : 40.0,
+    "minimumReactivePowerOutput" : 0.0,
+    "voltageMagnitudeSetpoint" : 1.01,
+    "totalMbase" : 100.0,
+    "status" : 1,
+    "maximumRealPowerOutput" : 100.0,
+    "minimumRealPowerOutput" : 0.0,
+    "pc1" : 0.0,
+    "pc2" : 0.0,
+    "qc1Min" : 0.0,
+    "qc1Max" : 0.0,
+    "qc2Min" : 0.0,
+    "qc2Max" : 0.0,
+    "rampAgc" : 0.0,
+    "rampTenMinutes" : 0.0,
+    "rampThirtyMinutes" : 0.0,
+    "rampQ" : 0.0,
+    "apf" : 0.0
+  }, {
+    "number" : 6,
+    "realPowerOutput" : 0.0,
+    "reactivePowerOutput" : 14.270293690387987,
+    "maximumReactivePowerOutput" : 24.0,
+    "minimumReactivePowerOutput" : -6.0,
+    "voltageMagnitudeSetpoint" : 1.07,
+    "totalMbase" : 100.0,
+    "status" : 1,
+    "maximumRealPowerOutput" : 100.0,
+    "minimumRealPowerOutput" : 0.0,
+    "pc1" : 0.0,
+    "pc2" : 0.0,
+    "qc1Min" : 0.0,
+    "qc1Max" : 0.0,
+    "qc2Min" : 0.0,
+    "qc2Max" : 0.0,
+    "rampAgc" : 0.0,
+    "rampTenMinutes" : 0.0,
+    "rampThirtyMinutes" : 0.0,
+    "rampQ" : 0.0,
+    "apf" : 0.0
+  }, {
+    "number" : 8,
+    "realPowerOutput" : 0.0,
+    "reactivePowerOutput" : 17.49238545332004,
+    "maximumReactivePowerOutput" : 24.0,
+    "minimumReactivePowerOutput" : -6.0,
+    "voltageMagnitudeSetpoint" : 1.09,
+    "totalMbase" : 100.0,
+    "status" : 1,
+    "maximumRealPowerOutput" : 100.0,
+    "minimumRealPowerOutput" : 0.0,
+    "pc1" : 0.0,
+    "pc2" : 0.0,
+    "qc1Min" : 0.0,
+    "qc1Max" : 0.0,
+    "qc2Min" : 0.0,
+    "qc2Max" : 0.0,
+    "rampAgc" : 0.0,
+    "rampTenMinutes" : 0.0,
+    "rampThirtyMinutes" : 0.0,
+    "rampQ" : 0.0,
+    "apf" : 0.0
+  } ],
+  "branches" : [ {
+    "from" : 1,
+    "to" : 2,
+    "r" : 0.01938,
+    "x" : 0.05917,
+    "b" : 0.0528,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 1,
+    "to" : 5,
+    "r" : 0.05403,
+    "x" : 0.22304,
+    "b" : 0.0492,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 2,
+    "to" : 3,
+    "r" : 0.04699,
+    "x" : 0.19797,
+    "b" : 0.0438,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 2,
+    "to" : 4,
+    "r" : 0.05811,
+    "x" : 0.17632,
+    "b" : 0.034,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 2,
+    "to" : 5,
+    "r" : 0.05695,
+    "x" : 0.17388,
+    "b" : 0.0346,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 3,
+    "to" : 4,
+    "r" : 0.06701,
+    "x" : 0.17103,
+    "b" : 0.0128,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 4,
+    "to" : 5,
+    "r" : 0.01335,
+    "x" : 0.04211,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 4,
+    "to" : 7,
+    "r" : 0.0,
+    "x" : 0.20912,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : -5.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 4,
+    "to" : 9,
+    "r" : 0.0,
+    "x" : 0.55618,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.969,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 5,
+    "to" : 6,
+    "r" : 0.0,
+    "x" : 0.25202,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.932,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 6,
+    "to" : 11,
+    "r" : 0.09498,
+    "x" : 0.1989,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 6,
+    "to" : 12,
+    "r" : 0.12291,
+    "x" : 0.25581,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 6,
+    "to" : 13,
+    "r" : 0.06615,
+    "x" : 0.13027,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 7,
+    "to" : 8,
+    "r" : 0.0,
+    "x" : 0.17615,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 7,
+    "to" : 9,
+    "r" : 0.0,
+    "x" : 0.11001,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 9,
+    "to" : 10,
+    "r" : 0.03181,
+    "x" : 0.0845,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 9,
+    "to" : 14,
+    "r" : 0.12711,
+    "x" : 0.27038,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 10,
+    "to" : 11,
+    "r" : 0.08205,
+    "x" : 0.19207,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 12,
+    "to" : 13,
+    "r" : 0.22092,
+    "x" : 0.19988,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  }, {
+    "from" : 13,
+    "to" : 14,
+    "r" : 0.17093,
+    "x" : 0.34802,
+    "b" : 0.0,
+    "rateA" : 0.0,
+    "rateB" : 0.0,
+    "rateC" : 0.0,
+    "ratio" : 0.0,
+    "phaseShiftAngle" : 0.0,
+    "status" : 1.0,
+    "angMin" : -360.0,
+    "angMax" : 360.0
+  } ]
+}
\ No newline at end of file
diff --git a/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.xiidm b/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.xiidm
new file mode 100644
index 00000000000..c03a80e4a3e
--- /dev/null
+++ b/matpower/matpower-converter/src/test/resources/ieee14-phase-shifter-zero-ratio-issue.xiidm
@@ -0,0 +1,139 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<iidm:network xmlns:iidm="http://www.powsybl.org/schema/iidm/1_13" xmlns:slt="http://www.powsybl.org/schema/iidm/ext/slack_terminal/1_5" id="ieee14-phase-shifter-zero-ratio-issue" caseDate="2020-01-01T00:00:00.000Z" forecastDistance="0" sourceFormat="MATPOWER" minimumValidationLevel="STEADY_STATE_HYPOTHESIS">
+    <iidm:substation id="SUB-1">
+        <iidm:voltageLevel id="VL-1" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-1" v="1.06" angle="0.0"/>
+            </iidm:busBreakerTopology>
+            <iidm:generator id="GEN-1" energySource="OTHER" minP="0.0" maxP="332.4" ratedS="100.0" voltageRegulatorOn="true" targetP="232.49989569603508" targetV="1.06" targetQ="-16.899907154008424" bus="BUS-1" connectableBus="BUS-1">
+                <iidm:minMaxReactiveLimits minQ="0.0" maxQ="10.0"/>
+            </iidm:generator>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-2">
+        <iidm:voltageLevel id="VL-2" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-2" v="1.0449999999999997" angle="-5.000328510465844"/>
+            </iidm:busBreakerTopology>
+            <iidm:generator id="GEN-2" energySource="OTHER" minP="0.0" maxP="140.0" ratedS="100.0" voltageRegulatorOn="true" targetP="40.0" targetV="1.045" targetQ="43.58509011714705" bus="BUS-2" connectableBus="BUS-2">
+                <iidm:minMaxReactiveLimits minQ="-40.0" maxQ="50.0"/>
+            </iidm:generator>
+            <iidm:load id="LOAD-2" loadType="UNDEFINED" p0="21.7" q0="12.7" bus="BUS-2" connectableBus="BUS-2"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-3">
+        <iidm:voltageLevel id="VL-3" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-3" v="1.01" angle="-12.78892335601888"/>
+            </iidm:busBreakerTopology>
+            <iidm:generator id="GEN-3" energySource="OTHER" minP="0.0" maxP="100.0" ratedS="100.0" voltageRegulatorOn="true" targetP="0.0" targetV="1.01" targetQ="25.247205918340796" bus="BUS-3" connectableBus="BUS-3">
+                <iidm:minMaxReactiveLimits minQ="0.0" maxQ="40.0"/>
+            </iidm:generator>
+            <iidm:load id="LOAD-3" loadType="UNDEFINED" p0="94.2" q0="19.0" bus="BUS-3" connectableBus="BUS-3"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-4">
+        <iidm:voltageLevel id="VL-4" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-4" v="1.0173494845822744" angle="-10.412306262257337"/>
+                <iidm:bus id="BUS-7" v="1.061731342223832" angle="-10.185085117783457"/>
+                <iidm:bus id="BUS-9" v="1.0582629220284285" angle="-12.65099581261227"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-4" loadType="UNDEFINED" p0="47.8" q0="-3.9" bus="BUS-4" connectableBus="BUS-4"/>
+            <iidm:load id="LOAD-9" loadType="UNDEFINED" p0="29.5" q0="16.6" bus="BUS-9" connectableBus="BUS-9"/>
+            <iidm:shunt id="SHUNT-9" sectionCount="1" voltageRegulatorOn="false" bus="BUS-9" connectableBus="BUS-9">
+                <iidm:shuntLinearModel bPerSection="19.0" maximumSectionCount="1"/>
+            </iidm:shunt>
+        </iidm:voltageLevel>
+        <iidm:twoWindingsTransformer id="TWT-4-7" r="0.0" x="0.0020912" g="0.0" b="0.0" ratedU1="1.0" ratedU2="1.0" voltageLevelId1="VL-4" bus1="BUS-4" connectableBus1="BUS-4" voltageLevelId2="VL-4" bus2="BUS-7" connectableBus2="BUS-7">
+            <iidm:phaseTapChanger lowTapPosition="0" tapPosition="0" regulationMode="FIXED_TAP">
+                <iidm:step r="0.0" x="0.0" g="0.0" b="0.0" rho="1.0" alpha="5.0"/>
+            </iidm:phaseTapChanger>
+        </iidm:twoWindingsTransformer>
+        <iidm:twoWindingsTransformer id="TWT-4-9" r="0.0" x="0.0055618" g="0.0" b="0.0" ratedU1="0.969" ratedU2="1.0" voltageLevelId1="VL-4" bus1="BUS-4" connectableBus1="BUS-4" voltageLevelId2="VL-4" bus2="BUS-9" connectableBus2="BUS-9"/>
+    </iidm:substation>
+    <iidm:substation id="SUB-5">
+        <iidm:voltageLevel id="VL-5" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-5" v="1.0200789534978287" angle="-8.724093100611777"/>
+                <iidm:bus id="BUS-6" v="1.07" angle="-13.22467775771849"/>
+            </iidm:busBreakerTopology>
+            <iidm:generator id="GEN-6" energySource="OTHER" minP="0.0" maxP="100.0" ratedS="100.0" voltageRegulatorOn="true" targetP="0.0" targetV="1.07" targetQ="14.270293690387987" bus="BUS-6" connectableBus="BUS-6">
+                <iidm:minMaxReactiveLimits minQ="-6.0" maxQ="24.0"/>
+            </iidm:generator>
+            <iidm:load id="LOAD-5" loadType="UNDEFINED" p0="7.6" q0="1.6" bus="BUS-5" connectableBus="BUS-5"/>
+            <iidm:load id="LOAD-6" loadType="UNDEFINED" p0="11.2" q0="7.5" bus="BUS-6" connectableBus="BUS-6"/>
+        </iidm:voltageLevel>
+        <iidm:twoWindingsTransformer id="TWT-5-6" r="0.0" x="0.0025202000000000002" g="0.0" b="0.0" ratedU1="0.932" ratedU2="1.0" voltageLevelId1="VL-5" bus1="BUS-5" connectableBus1="BUS-5" voltageLevelId2="VL-5" bus2="BUS-6" connectableBus2="BUS-6"/>
+    </iidm:substation>
+    <iidm:substation id="SUB-8">
+        <iidm:voltageLevel id="VL-8" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-8" v="1.09" angle="-10.185085117783467"/>
+            </iidm:busBreakerTopology>
+            <iidm:generator id="GEN-8" energySource="OTHER" minP="0.0" maxP="100.0" ratedS="100.0" voltageRegulatorOn="true" targetP="0.0" targetV="1.09" targetQ="17.49238545332004" bus="BUS-8" connectableBus="BUS-8">
+                <iidm:minMaxReactiveLimits minQ="-6.0" maxQ="24.0"/>
+            </iidm:generator>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-10">
+        <iidm:voltageLevel id="VL-10" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-10" v="1.0531461836881817" angle="-13.035710471997398"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-10" loadType="UNDEFINED" p0="9.0" q0="5.8" bus="BUS-10" connectableBus="BUS-10"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-11">
+        <iidm:voltageLevel id="VL-11" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-11" v="1.0582558695370825" angle="-13.25292235374066"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-11" loadType="UNDEFINED" p0="3.5" q0="1.8" bus="BUS-11" connectableBus="BUS-11"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-12">
+        <iidm:voltageLevel id="VL-12" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-12" v="1.0551462766263606" angle="-13.988186540628082"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-12" loadType="UNDEFINED" p0="6.1" q0="1.6" bus="BUS-12" connectableBus="BUS-12"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-13">
+        <iidm:voltageLevel id="VL-13" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-13" v="1.0509495051495474" angle="-13.97721516091526"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-13" loadType="UNDEFINED" p0="13.5" q0="5.8" bus="BUS-13" connectableBus="BUS-13"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:substation id="SUB-14">
+        <iidm:voltageLevel id="VL-14" nominalV="1.0" lowVoltageLimit="0.94" highVoltageLimit="1.06" topologyKind="BUS_BREAKER">
+            <iidm:busBreakerTopology>
+                <iidm:bus id="BUS-14" v="1.037140277380203" angle="-14.223902738389041"/>
+            </iidm:busBreakerTopology>
+            <iidm:load id="LOAD-14" loadType="UNDEFINED" p0="14.9" q0="5.0" bus="BUS-14" connectableBus="BUS-14"/>
+        </iidm:voltageLevel>
+    </iidm:substation>
+    <iidm:line id="LINE-1-2" r="1.9380000000000002E-4" x="5.917E-4" g1="0.0" b1="2.64" g2="0.0" b2="2.64" voltageLevelId1="VL-1" bus1="BUS-1" connectableBus1="BUS-1" voltageLevelId2="VL-2" bus2="BUS-2" connectableBus2="BUS-2"/>
+    <iidm:line id="LINE-1-5" r="5.403000000000001E-4" x="0.0022304" g1="0.0" b1="2.46" g2="0.0" b2="2.46" voltageLevelId1="VL-1" bus1="BUS-1" connectableBus1="BUS-1" voltageLevelId2="VL-5" bus2="BUS-5" connectableBus2="BUS-5"/>
+    <iidm:line id="LINE-2-3" r="4.699E-4" x="0.0019797" g1="0.0" b1="2.19" g2="0.0" b2="2.19" voltageLevelId1="VL-2" bus1="BUS-2" connectableBus1="BUS-2" voltageLevelId2="VL-3" bus2="BUS-3" connectableBus2="BUS-3"/>
+    <iidm:line id="LINE-2-4" r="5.811E-4" x="0.0017632000000000001" g1="0.0" b1="1.7000000000000002" g2="0.0" b2="1.7000000000000002" voltageLevelId1="VL-2" bus1="BUS-2" connectableBus1="BUS-2" voltageLevelId2="VL-4" bus2="BUS-4" connectableBus2="BUS-4"/>
+    <iidm:line id="LINE-2-5" r="5.695E-4" x="0.0017388" g1="0.0" b1="1.73" g2="0.0" b2="1.73" voltageLevelId1="VL-2" bus1="BUS-2" connectableBus1="BUS-2" voltageLevelId2="VL-5" bus2="BUS-5" connectableBus2="BUS-5"/>
+    <iidm:line id="LINE-3-4" r="6.701E-4" x="0.0017102999999999999" g1="0.0" b1="0.64" g2="0.0" b2="0.64" voltageLevelId1="VL-3" bus1="BUS-3" connectableBus1="BUS-3" voltageLevelId2="VL-4" bus2="BUS-4" connectableBus2="BUS-4"/>
+    <iidm:line id="LINE-4-5" r="1.3350000000000002E-4" x="4.211E-4" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-4" bus1="BUS-4" connectableBus1="BUS-4" voltageLevelId2="VL-5" bus2="BUS-5" connectableBus2="BUS-5"/>
+    <iidm:line id="LINE-6-11" r="9.498E-4" x="0.001989" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-5" bus1="BUS-6" connectableBus1="BUS-6" voltageLevelId2="VL-11" bus2="BUS-11" connectableBus2="BUS-11"/>
+    <iidm:line id="LINE-6-12" r="0.0012291000000000001" x="0.0025581" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-5" bus1="BUS-6" connectableBus1="BUS-6" voltageLevelId2="VL-12" bus2="BUS-12" connectableBus2="BUS-12"/>
+    <iidm:line id="LINE-6-13" r="6.615E-4" x="0.0013027" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-5" bus1="BUS-6" connectableBus1="BUS-6" voltageLevelId2="VL-13" bus2="BUS-13" connectableBus2="BUS-13"/>
+    <iidm:line id="LINE-7-8" r="0.0" x="0.0017615" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-4" bus1="BUS-7" connectableBus1="BUS-7" voltageLevelId2="VL-8" bus2="BUS-8" connectableBus2="BUS-8"/>
+    <iidm:line id="LINE-7-9" r="0.0" x="0.0011001" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-4" bus1="BUS-7" connectableBus1="BUS-7" voltageLevelId2="VL-4" bus2="BUS-9" connectableBus2="BUS-9"/>
+    <iidm:line id="LINE-9-10" r="3.181E-4" x="8.45E-4" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-4" bus1="BUS-9" connectableBus1="BUS-9" voltageLevelId2="VL-10" bus2="BUS-10" connectableBus2="BUS-10"/>
+    <iidm:line id="LINE-9-14" r="0.0012711" x="0.0027038" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-4" bus1="BUS-9" connectableBus1="BUS-9" voltageLevelId2="VL-14" bus2="BUS-14" connectableBus2="BUS-14"/>
+    <iidm:line id="LINE-10-11" r="8.204999999999999E-4" x="0.0019207" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-10" bus1="BUS-10" connectableBus1="BUS-10" voltageLevelId2="VL-11" bus2="BUS-11" connectableBus2="BUS-11"/>
+    <iidm:line id="LINE-12-13" r="0.0022092" x="0.0019988000000000002" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-12" bus1="BUS-12" connectableBus1="BUS-12" voltageLevelId2="VL-13" bus2="BUS-13" connectableBus2="BUS-13"/>
+    <iidm:line id="LINE-13-14" r="0.0017093" x="0.0034802" g1="0.0" b1="0.0" g2="0.0" b2="0.0" voltageLevelId1="VL-13" bus1="BUS-13" connectableBus1="BUS-13" voltageLevelId2="VL-14" bus2="BUS-14" connectableBus2="BUS-14"/>
+    <iidm:extension id="VL-1">
+        <slt:slackTerminal id="GEN-1"/>
+    </iidm:extension>
+</iidm:network>
\ No newline at end of file
diff --git a/matpower/matpower-model/src/main/java/com/powsybl/matpower/model/MatpowerModelFactory.java b/matpower/matpower-model/src/main/java/com/powsybl/matpower/model/MatpowerModelFactory.java
index 0b75311bcf5..752ca3da566 100644
--- a/matpower/matpower-model/src/main/java/com/powsybl/matpower/model/MatpowerModelFactory.java
+++ b/matpower/matpower-model/src/main/java/com/powsybl/matpower/model/MatpowerModelFactory.java
@@ -31,7 +31,7 @@ private static MatpowerModel readModelJsonFromResources(ObjectMapper mapper, Str
         return model;
     }
 
-    private static MatpowerModel readModelJsonFromResources(String fileName) {
+    public static MatpowerModel readModelJsonFromResources(String fileName) {
         return readModelJsonFromResources(new ObjectMapper(), fileName);
     }