Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using ComparisonUtils::compareXml in CI #2817

Open
flo-dup opened this issue Dec 4, 2023 · 0 comments
Open

Avoid using ComparisonUtils::compareXml in CI #2817

flo-dup opened this issue Dec 4, 2023 · 0 comments

Comments

@flo-dup
Copy link
Contributor

flo-dup commented Dec 4, 2023

Describe the current behavior

ComparisonUtils::compareXml is used in unit tests

Describe the expected behavior

ComparisonUtils::compareXml is not used in the CI to reduce the corresponding time cost.
ComparisonUtils::compareTxt or Files::mismatch used instead

Describe the motivation

Reduce time spent in CI

Extra Information

With the TreeDataReader/Writer and JSON format we now enforce a precise attribute order in reading/writing. Hence we could use compareTxt at the cost of updating many (if not all) reference unit tests. We might go further and use the byte-by-byte comparison instead, but the line separators would probably cause an issue on Windows CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant