You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These methods return the default parameters from their respective Provider/Importer/Exporter implementations. However, they do not account for the default parameter overrides specified in the PlatformConfig (in .itools/config.yml).
should retrieve a List<Parameter> that reflects both the default parameters set in their respective Provider/Importer/Exporter implementations and any overrides specified in the PlatformConfig (in .itools/config.yml).
For instance, in open-loadflow, instead of returning a hard-coded list of default parameters, the method should dynamically generate this list, incorporating any overrides defined under open-loadflow-default-parameters: in .itools/config.yml. This ensures that the parameters retrieved are synchronized with the ones specified in the PlatformConfig.
Describe the motivation
In GridSuite, we retrieve the List<Parameter> from providers/importers and only save the parameters that differ from this list. However, the current implementation of these methods is not synchronized with the actual parameters used in the calculation, as it does not account for the PlatformConfig overrides.
Due to this discrepancy, we must manually hard-code the overrides in the code, as there is no straightforward way to retrieve the default parameters with the PlatformConfig overrides applied. This adds complexity and redundancy.
For example, in the LoadFlow parameters, LoadFlowService.java#L81-L97, there is a manual override that would be unnecessary if the methods accurately reflected the PlatformConfig settings. Synchronizing these methods with PlatformConfig would simplify parameter management. We would only need to modify the default parameters in .itools/config.yml with no code addition.
Extra Information
No response
The text was updated successfully, but these errors were encountered:
Describe the current behavior
In the current implementation, we can retrieve a
List<Parameter>
from the following methods:These methods return the default parameters from their respective Provider/Importer/Exporter implementations. However, they do not account for the default parameter overrides specified in the
PlatformConfig
(in.itools/config.yml
).For example, in open-loadflow, the method returns a hard-coded list of default parameters: https://github.com/powsybl/powsybl-open-loadflow/blob/3404c7fa00058d278f0a78915653cab4e103a5b3/src/main/java/com/powsybl/openloadflow/OpenLoadFlowProvider.java#L312.
The issue is that this list is not synchronized with the parameters actually used in the calculation, which correctly accounts for the
PlatformConfig
if the default parameters are overridden withopen-loadflow-default-parameters:
in.itools/config.yml
.Describe the expected behavior
should retrieve a
List<Parameter>
that reflects both the default parameters set in their respective Provider/Importer/Exporter implementations and any overrides specified in thePlatformConfig
(in.itools/config.yml
).For instance, in open-loadflow, instead of returning a hard-coded list of default parameters, the method should dynamically generate this list, incorporating any overrides defined under open-loadflow-default-parameters: in
.itools/config.yml
. This ensures that the parameters retrieved are synchronized with the ones specified in thePlatformConfig
.Describe the motivation
In GridSuite, we retrieve the
List<Parameter>
from providers/importers and only save the parameters that differ from this list. However, the current implementation of these methods is not synchronized with the actual parameters used in the calculation, as it does not account for thePlatformConfig
overrides.Due to this discrepancy, we must manually hard-code the overrides in the code, as there is no straightforward way to retrieve the default parameters with the
PlatformConfig
overrides applied. This adds complexity and redundancy.For example, in the LoadFlow parameters, LoadFlowService.java#L81-L97, there is a manual override that would be unnecessary if the methods accurately reflected the
PlatformConfig
settings. Synchronizing these methods withPlatformConfig
would simplify parameter management. We would only need to modify the default parameters in.itools/config.yml
with no code addition.Extra Information
No response
The text was updated successfully, but these errors were encountered: