Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the computation of invisible nodes used in NetworkGraphBuilder #497

Open
So-Fras opened this issue Feb 3, 2023 · 0 comments
Open
Assignees
Projects

Comments

@So-Fras
Copy link
Collaborator

So-Fras commented Feb 3, 2023

  • Do you want to request a feature or report a bug?
    Improvement on current code without changing its behavior.

  • What is the current behavior?
    The function getNextDepthVoltageLevels in VoltageLevelFilter is used to find the invisible neighboring nodes of the graph visible nodes. This function is not optimal, especially if a very large list of voltageLevels is passed as an input parameter.

  • What is the expected behavior?
    The behavior of the NetworkGraphBuilder should not change but the invisible nodes should be collected in a less resource-guzzling way, by reusing a slightly modified traverseVoltageLevels function.

  • What is the motivation / use case for changing the behavior?
    Improve performance / clean code

  • Please tell us about your environment:

    • PowSyBl Version: 5.1.1
@So-Fras So-Fras self-assigned this Feb 3, 2023
@So-Fras So-Fras added this to In progress in V3.2.0 Feb 3, 2023
@So-Fras So-Fras moved this from In progress to In a future release in V3.2.0 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
V3.2.0
In a future release
Development

No branches or pull requests

1 participant