Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some attributes from PositionVoltageLevelLayoutFactory to LayoutParameters #503

Open
So-Fras opened this issue Mar 9, 2023 · 0 comments
Open

Move some attributes from PositionVoltageLevelLayoutFactory to LayoutParameters #503

So-Fras opened this issue Mar 9, 2023 · 0 comments
Labels
enhancement New feature or request SLD

Comments

@So-Fras
Copy link
Collaborator

So-Fras commented Mar 9, 2023

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    The PositionVoltageLevelLayoutFactory class has some attributes that would maybe fit in better with the LayoutParameters class.

  • What is the expected behavior?
    Some attributes (feederStacked, removeUnecessaryFictitiousNodes, substituteSingularFictitiousByFeederNode, ...) moved into the LayoutParameters class.

  • What is the motivation / use case for changing the behavior?
    It would be more user-friendly, especially for users who are new to powsybl-diagram to have those parameters in the LayoutParameters rather than in the PositionVoltageLevelLayoutFactory
@So-Fras So-Fras added enhancement New feature or request SLD labels Mar 9, 2023
@So-Fras So-Fras mentioned this issue Mar 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request SLD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@So-Fras