Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify situation with respect to multiple networks in the same networkstoreservice #422

Open
jonenst opened this issue Jul 30, 2024 · 0 comments

Comments

@jonenst
Copy link
Collaborator

jonenst commented Jul 30, 2024

Describe the current behavior

We have a lot of code in the different caches/buffers to deal with multiple networks (e.g.

return collections.computeIfAbsent(Pair.of(networkUuid, variantNum), p -> factory.get());
) but NetworkStoreService always recreates the client (and also the networkfactory) :

return new NetworkFactoryImpl(() -> decorator.apply(restClient, getNonNullPreloadingStrategy(preloadingStrategy), executorService));

return getNetworkFactory(preloadingStrategy).createNetwork(id, sourceFormat);

Network network = importer.importData(dataSource, getNetworkFactory(preloadingStrategy), parameters, reporter);

NetworkStoreClient storeClient = decorator.apply(restClient, getNonNullPreloadingStrategy(preloadingStrategy), executorService);

Describe the expected behavior

make the system more complete and regular

Describe the motivation

No response

Extra Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant