Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple generators connected to same bus controlling voltage of a different bus #552

Open
geofjamg opened this issue Jun 13, 2022 · 2 comments

Comments

@geofjamg
Copy link
Member

geofjamg commented Jun 13, 2022

  • Do you want to request a feature or report a bug?
    Feature

  • What is the current behavior?
    If we have several generators connected to same bus but controlling voltage of different buses we have the following exception:

"Generators [_ee520ab7-786a-499b-a3ae-d96fb5b12596, _9064117a-2da4-46db-b1ee-f60810974a76] connected to bus '_55207717-1417-458c-9b5f-e67a3eedc46a_0' must control the voltage of the same bus".
  • What is the expected behavior?
    We can support this case by just adaping the LF network creation (so without any change in the equations) by just creating FakeLfBus in addition to real LfBus for other generators connected to the bus and by linking FakeLfBus to real LfBus with a FakeLfSwitch. Fake or fictitious in that case means there is no equivalent object in IIDM.

  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@geofjamg
Copy link
Member Author

geofjamg commented Aug 29, 2022

@annetill after thinking again and prototyping the proposed solution (not working...) I am wondering if the real and clean solution is to move controller from LfBus to LfGenerator. So the VoltageControl class will reference LFGenerators as controllers. voltageControlEnabled will move to LfGenerator too. It will kind of complexify some part of the code but it will be probably cleaner as controller are LfGenerator and not LfBus (On LfBus it is an aggregated view). And this is exactly what we did for ShuntVoltageControl where controllers are LfShunt and not LfBus.

@annetill
Copy link
Member

Can I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants