Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futureproof compatibility with pymatgen #204

Open
ml-evs opened this issue Mar 27, 2024 · 0 comments
Open

Futureproof compatibility with pymatgen #204

ml-evs opened this issue Mar 27, 2024 · 0 comments

Comments

@ml-evs
Copy link
Collaborator

ml-evs commented Mar 27, 2024

Currently we are in a state where we cannot update pymatgen any further than what is done in #203 without our tests failing. This is because our test data was created with a 2022.* version of pymatgen, and pickled directly by MODData.save(...). Whilst all the information is there to reconstruct the pymatgen objects, several private attributes added to pymatgen in the meantime are missing, so the direct depickling approach fails.

I don't know if we want to hack in our own backwards compatibility with pymatgen, but really we should have a better serialization process that uses something like structure.to_dict() rather than pickle, although this would have to interact with our existing approach of saving MODNet models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant