predict method of EnsembleMODNetModel does not correspond to majority vote for classification tasks

[kaueltzen]

Hi,

thanks for the nice package!

I have a remark about the EnsembleMODNetModel class: the predict method always corresponds to the mean of the predictions of the ensemble:

modnet/modnet/models/ensemble.py

Line 178 in e14188d

p_mean = np.array(all_predictions).mean(axis=0)

However, for classification tasks, this may result in non-integer labels and one would, for example, fail to compute an f1 score with such a prediction. If you are interested, I would be happy to implement hard and / or soft voting for classification ensembles here.

[ppdebreuck]

Hi @kaueltzen ! This is indeed true, however one could still convert it to discrete classes by putting a threshold. But I agree the latter makes more sense to be used in combinateion of return_prob=True. So what you suggest (hard and / or soft voting) makes sense! Please go ahead with what makes sense to you and happy to review :)