From 1326609f665f6f202301bc6f7945d49e3cd1b72c Mon Sep 17 00:00:00 2001 From: Lucas Prates Date: Mon, 18 Dec 2023 11:59:26 +0000 Subject: [PATCH] fixup! [AsmWriter] Ensure getMnemonic doesn't return invalid pointers --- llvm/lib/MC/MCAsmStreamer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llvm/lib/MC/MCAsmStreamer.cpp b/llvm/lib/MC/MCAsmStreamer.cpp index 532ac89bf9ff76..49668de27d67e7 100644 --- a/llvm/lib/MC/MCAsmStreamer.cpp +++ b/llvm/lib/MC/MCAsmStreamer.cpp @@ -154,10 +154,10 @@ class MCAsmStreamer final : public MCStreamer { void emitGNUAttribute(unsigned Tag, unsigned Value) override; StringRef getMnemonic(MCInst &MI) override { - std::pair M = InstPrinter->getMnemonic(&MI); - assert((M.second != 0 || M.first == nullptr) && + auto [Ptr, Bits] = InstPrinter->getMnemonic(&MI); + assert((Bits != 0 || Ptr == nullptr) && "Invalid char pointer for instruction with no mnemonic"); - return M.first; + return Ptr; } void emitLabel(MCSymbol *Symbol, SMLoc Loc = SMLoc()) override;