Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer should record number of events and bytes unacknowledged #56

Open
claudiofahey opened this issue Sep 4, 2019 · 6 comments
Open

Comments

@claudiofahey
Copy link

No description provided.

@kmgowda
Copy link
Contributor

kmgowda commented Sep 6, 2019

This have shared int implementation for multi thread cause the sync issues and in turn reduces the strength of tool to pump more data to pravega client.

@claudiofahey
Copy link
Author

FYI I have a branch that implements this.
I will create a PR shortly.
https://github.com/claudiofahey/pravega-benchmark/tree/issue-56-track-unacked

@kmgowda
Copy link
Contributor

kmgowda commented Sep 6, 2019

include me @kmgowda as reviewer

@claudiofahey
Copy link
Author

I created PR #59. I do not have access to add you as a reviewer. Can you add me to this repo?

@RaulGracia
Copy link
Contributor

@claudiofahey are you still interested on submitting the PR for this issue?

@claudiofahey
Copy link
Author

Yes but I don't know when I'll have time to finish this. If this is needed soon, it would be better for somebody else to pick this up. My original solution to this is at 163da48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants