Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure in stringifying on 1.717 for Mojolicious < 8.22 #101

Open
duffee opened this issue Aug 18, 2023 · 1 comment
Open

Test failure in stringifying on 1.717 for Mojolicious < 8.22 #101

duffee opened this issue Aug 18, 2023 · 1 comment

Comments

@duffee
Copy link

duffee commented Aug 18, 2023

Found this test fail today when building Log::Any 1.717 with Mojolicious 7 (which caused confusion when "well, it worked on my machine" with an up-to-date Mojo).

#   Failed test 'default log with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'

#   Failed test 'proxy log with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'

#   Failed test 'proxy log show args with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'
# Looks like you failed 3 tests of 241.

Mojolicious fixed this in 8.22

Temporary solution will be to pin the Log::Any version until Mojo Is upgraded Another of our dependancies pulls in the latest version of Log::Any, foiling the pin in our cpanfile. Installing sooner in the build pipeline.

Raising the issue for awareness.

@dakkar
Copy link

dakkar commented Aug 21, 2023

since Mojolicious is not a dependency of Log::Any, I'd suggest tweaking the tests to accept the old behaviour as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants