Proposal: unmatched optional path segments produce undefined prop values #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, optional path segments that do not match a current URL produce same-named props with an empty string value:
With this PR, the value for optional path segments that have no match is an empty string. Matched path segments that are empty will still produce an empty string.
This is a major change, because it means any
defaultProps
for route components will be applied for empty/missing route parameters - currently they are not.Fixes #381.
ToDo