rollup version is too old (is fake) #923

Aloento · 2022-04-12T17:59:51Z

"@wmrjs/service-worker@^0.3.1":
  version "0.3.1"
  dependencies:
    rollup "^2.0.0"

rollup@^2.0.0:
  version "2.70.1"

then "@rollup/plugin-commonjs" requires at least rollup@2.38 but found rollup@2.8.0.
Cannot fix this by yarn add -D rollup

I recommend you to use the dependence bot or npm-check-updates to keep new for your deps.

The text was updated successfully, but these errors were encountered:

rschristian · 2022-04-12T21:01:12Z

We're using Rollup 2.52.7:

wmr/packages/wmr/package.json

Line 81 in caf7ff8

"rollup": "^2.52.7",

Our deps are all inlined, so if you have rollup in your lock file then it hasn't come from installing WMR.

Aloento · 2022-04-12T21:07:05Z

I know wmr is new but my old rollup is from your package @wmrjs/service-worker
It's also your package, or maybe you don't maintain this package, then I will remove it.

rschristian · 2022-04-12T21:08:27Z

Your lock file clearly shows it resolving to 2.70, so I don't know what is referring to 2.8, but it's not us I don't think.

Aloento · 2022-04-12T21:11:58Z

Yes, I am also confused about this.
I try to look for the node_modules and see what exactly the version is.
And it's the newest version of rollup but, the plug-in always says it's the old version.
I use a new project and I will show you the debug things.

Aloento · 2022-04-12T21:18:17Z

SoarT@Soar-Blade ~\Downloads\WMR ❯❯❯ yarn run start
Debugger attached.
yarn run v1.22.18
$ wmr
Debugger attached.

Error: Insufficient Rollup version: "@rollup/plugin-commonjs" requires at least rollup@2.38 but found rollup@2.8.0.
    at validateRollupVersion (C:\Users\SoarT\Downloads\WMR\node_modules\@rollup\plugin-commonjs\dist\index.js:682:11)
    at Object.buildStart (C:\Users\SoarT\Downloads\WMR\node_modules\@rollup\plugin-commonjs\dist\index.js:1791:7)
    at C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:2973713
    at Array.map (<anonymous>)
    at Object.buildStart (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:2973677)
    at Dwt (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:3009029)
    at eDt (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:3021787)
    at async Zwt (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:3021244)

Waiting for the debugger to disconnect...
error Command failed with exit code 1.

rschristian · 2022-04-12T21:24:01Z

Why are you installing @rollup/plugin-commonjs out of curiosity? I could not reproduce the error locally when adding @wmrjs/service-worker to an app.

Aloento · 2022-04-12T21:27:33Z

reproduce this error just with
yarn add @rollup/plugin-commonjs

wmr.config.mjs
import commonjs from "@rollup/plugin-commonjs";
plugins: [commonjs()],

then you cannot start wmr.

I'm trying to solve this problem so I add @rollup/plugin-commonjs
Currently, I can't use WMR to working my project at all.

rschristian · 2022-04-12T21:35:49Z

Hm, still cannot reproduce that error. Can you clear node_modules and your lock file and try installing again? What version of Yarn are you using? I'm on 1.22.18 which seems to be working.

All I've done is create a new project, add that plugin, and add it to the config. Is that a correct reproduction?

Aloento · 2022-04-12T21:42:44Z

Let me clean everything and restart my computer, then see what will happen.

Ok, still wrong...

Let me use Linux to try again.

Not working.... outrageous

rschristian · 2022-04-12T21:56:49Z

Can you try cloning and running this?

https://github.com/rschristian/wmr-rollup-cjs

Try installing with yarn --frozen-lockfile

Aloento · 2022-04-12T21:59:20Z

this is my env, I will try yours.
https://github.com/Aloento/WMR

Still wrong...
I suspect there may be something wrong with my environment.
Let me open a virtual machine and try it.

rschristian · 2022-04-12T22:13:21Z

I'm on Linux,, using Yarn v1 (1.22.18), if it helps. Bizarre issue.

Aloento · 2022-04-12T22:15:17Z

Still wrong in clean Win 11 virtual machine (Sandbox).
With nodejs 17.9.0 and yarn v1.22.18
I now try with Linux virtual machine.

Still wrong... omg...

rschristian · 2022-04-12T22:19:25Z

I'm on Node 14.19.1, though I don't think anything's really changed there.

Aloento · 2022-04-12T22:31:37Z

I tried with your node version and it's started but still thrown... funny...

(node:6804) UnhandledPromiseRejectionWarning: Error: Insufficient Rollup version: "@rollup/plugin-commonjs" requires at least rollup@2.38 but found rollup@2.8.0.
    at validateRollupVersion (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\@rollup\plugin-commonjs\dist\index.js:682:11)
    at Object.buildStart (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\@rollup\plugin-commonjs\dist\index.js:1791:7)
    at C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\wmr\wmr.cjs:2:2973713
    at Array.map (<anonymous>)
    at Object.buildStart (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\wmr\wmr.cjs:2:2973677)
    at Dwt (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\wmr\wmr.cjs:2:3009029)
    at eDt (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\wmr\wmr.cjs:2:3021787)
    at async Zwt (C:\Users\WDAGUtilityAccount\Desktop\wmr-rollup-cjs-master\node_modules\wmr\wmr.cjs:2:3021244)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:6804) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:6804) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

  👩‍🚀 WMR dev server running at:

  Local:   http://localhost:8080
  Network: (disabled, see --host)

And the page cannot be showing.

I'm giving up.

rschristian · 2022-04-12T22:36:05Z

Shoot, I'm really sorry, I didn't notice you were running the dev server.

I can reproduce there. Can you confirm that wmr build doesn't result in that error?

Aloento · 2022-04-12T22:39:30Z

SoarT@Soar-Blade ~\Downloads\WMR git:master ❯❯❯ yarn run build
Debugger attached.
yarn run v1.22.18
$ wmr build --prerender
Debugger attached.

SyntaxError: Unexpected token: punc (:)
  1 | …
> 2 | …pos=i}}function nd(e,t,n,r,i){throw new td(e,t,n,r,i)}function rd(e,t,n){…
    |                                      ^

    at nd (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:399363)
    at B (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:408097)
    at c (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:408188)
    at l (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:408241)
    at m (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:408780)
    at _ (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:412876)
    at e (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:409997)
    at C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:408887
    at E (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:412606)
    at e (C:\Users\SoarT\Downloads\WMR\node_modules\wmr\wmr.cjs:2:409993)

Waiting for the debugger to disconnect...
error Command failed with exit code 1.

rschristian · 2022-04-12T22:40:49Z

Well... different error is progress?

developit · 2022-04-12T22:41:11Z

The official Rollup commonjs plugin won't work with WMR's dev server, because it's not a full Rollup implementation. The version number is fake, but even if that were updated this wouldn't work - it's missing things like the plugin metadata API. Also, the way the CommonJS plugin works is extremely complex and retains data across multiple plugin passes, which does not work with the model WMR uses where each file is an individual HTTP request.

That error looks like TypeScript is being authored in a non-TypeScript file (.js or .mjs).

Aloento · 2022-04-12T22:43:36Z

uh... I didn't write any type...
#922 should reopen...
So do you have any solution for the commonjs?

rschristian · 2022-04-12T22:52:03Z

@developit Interestingly the package that's throwing the error (react-helmet-async) is one built with Microbundle.... Granted might be in one of the deps, the error position doesn't exactly make it clear.

developit · 2022-04-13T03:23:11Z

@rschristian I thought it was because of the scheduler package?

rschristian · 2022-04-13T03:42:14Z

They've had two separate issues with two separate packages:

@fluentui/react-components leads to scheduler
react-helmet-async leads to the above Unexpected punc (:). As for where that token is, no clue, as we don't seem to create a stack trace that actually identifies where it's from.

Aloento added the bug Something isn't working label Apr 12, 2022

Aloento closed this as completed Apr 12, 2022

rschristian reopened this Apr 12, 2022

Aloento changed the title ~~rollup version is too old~~ rollup version is too old (is fake) Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rollup version is too old (is fake) #923

rollup version is too old (is fake) #923

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022

rschristian commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022

developit commented Apr 12, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022 •

edited

Loading

developit commented Apr 13, 2022

rschristian commented Apr 13, 2022

rollup version is too old (is fake) #923

rollup version is too old (is fake) #923

Comments

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022 • edited Loading

Aloento commented Apr 12, 2022

rschristian commented Apr 12, 2022 • edited Loading

Aloento commented Apr 12, 2022 • edited Loading

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022

developit commented Apr 12, 2022

Aloento commented Apr 12, 2022 • edited Loading

rschristian commented Apr 12, 2022 • edited Loading

developit commented Apr 13, 2022

rschristian commented Apr 13, 2022

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

Aloento commented Apr 12, 2022 •

edited

Loading

rschristian commented Apr 12, 2022 •

edited

Loading