Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: Add bidder response to raw bidder response stage payload #3882

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

ashishshinde-pubm
Copy link
Contributor

@ashishshinde-pubm ashishshinde-pubm commented Aug 25, 2024

Currently, there is no way to determine the currency of the bids returned in the bidder-response during the raw_bidder_response_stage.
There are several use cases where it is important to know the currency of the bidder-response at this stage.
This PR addresses the issue by introducing the bidder-response itself, rather than just bidder-response.Bids, at this stage.

@ashishshinde-pubm
Copy link
Contributor Author

Hi @bsardo
Please review this PR and let me know if any changes are required.

@bsardo bsardo self-assigned this Oct 19, 2024
@bsardo bsardo changed the title Introduce bidderResponse in raw_bidder_response_stage Modules: Add bidder response to raw bidder response stage payload Oct 21, 2024
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 3f413a0 into prebid:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants